Skip to content

Commit e0814ee

Browse files
committed
fix: improve setup.py for Python 3.12+ compatibility
- Add proper requirements.txt parsing with comment filtering - Update package name to follow kebab-case convention - Add python_requires constraint (>=3.8) - Improve version string format (1.0.0) This resolves packaging compatibility issues encountered when installing with pip in Python 3.12+ environments.
1 parent 92713df commit e0814ee

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

setup.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,15 @@
99
from setuptools import setup, find_packages
1010

1111
with open("requirements.txt") as f:
12-
requirements = f.readlines()
12+
requirements = [line.strip() for line in f.readlines() if line.strip() and not line.startswith('#')]
1313

1414
setup(
15-
name="My app",
16-
version="1.0",
15+
name="my-app",
16+
version="1.0.0",
1717
description="Python Apache Beam pipeline.",
1818
author="My name",
1919
author_email="my@email.com",
2020
packages=find_packages(),
2121
install_requires=requirements,
22+
python_requires=">=3.8",
2223
)

0 commit comments

Comments
 (0)