Skip to content

Commit 04f6c50

Browse files
committed
Upgrade collection hint from INFO to WARN per reviewer feedback
1 parent 877547d commit 04f6c50

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignatures.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2371,11 +2371,10 @@ private static void warnIfValueStateContainsCollection(
23712371
}
23722372

23732373
if (recommendation != null) {
2374-
LOG.info(
2374+
LOG.warn(
23752375
"DoFn {} declares ValueState '{}' with collection type {}. "
23762376
+ "ValueState reads/writes the entire collection on each access. "
2377-
+ "This is appropriate for small collections or atomic replacement. "
2378-
+ "For large collections or frequent appends, consider using {} instead "
2377+
+ "For large or frequently-updated collections, consider using {} instead "
23792378
+ "(if supported by your runner).",
23802379
fnClazz.getSimpleName(),
23812380
stateId,

0 commit comments

Comments
 (0)