Skip to content

Commit 095f3ea

Browse files
authored
Suppress log spams in gcsio 3.0 (#38588) (#38593)
1 parent b4d33c5 commit 095f3ea

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

  • sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util

sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilV1.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171
import java.util.concurrent.LinkedBlockingQueue;
7272
import java.util.concurrent.ThreadPoolExecutor;
7373
import java.util.concurrent.TimeUnit;
74+
import java.util.concurrent.atomic.AtomicBoolean;
7475
import java.util.concurrent.atomic.AtomicInteger;
7576
import java.util.function.Consumer;
7677
import java.util.function.Supplier;
@@ -184,6 +185,7 @@ public boolean shouldRetry(IOException e) {
184185
return RetryDeterminer.SOCKET_ERRORS.shouldRetry(e);
185186
}
186187
};
188+
private static final AtomicBoolean overwriteLog = new AtomicBoolean(false);
187189

188190
/////////////////////////////////////////////////////////////////////////////
189191

@@ -726,9 +728,16 @@ public WritableByteChannel create(GcsPath path, CreateOptions options) throws IO
726728
}
727729
}
728730

731+
@SuppressFBWarnings("LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE")
729732
GoogleCloudStorage createGoogleCloudStorage(
730733
GoogleCloudStorageOptions options, Storage storage, Credentials credentials)
731734
throws IOException {
735+
// Suppress log spams in gcsio 3.0
736+
if (overwriteLog.compareAndSet(false, true)) {
737+
java.util.logging.Logger.getLogger("com.google.cloud.hadoop.gcsio.GoogleCloudStorageImpl")
738+
.setLevel(java.util.logging.Level.SEVERE);
739+
}
740+
732741
return GoogleCloudStorageImpl.builder()
733742
.setOptions(options)
734743
.setHttpTransport(storage.getRequestFactory().getTransport())

0 commit comments

Comments
 (0)