Skip to content

Commit 09c962c

Browse files
authored
Fix Milvus ML PreCommit xdist, container startup (#39007)
1 parent 466989d commit 09c962c

4 files changed

Lines changed: 4 additions & 1 deletion

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"comment": "Modify this file in a trivial way to cause this test suite to run",
3-
"revision": 3
3+
"revision": 7
44
}

sdks/python/apache_beam/ml/rag/enrichment/milvus_search_it_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,7 @@ def __getitem__(self, key):
225225

226226

227227
@pytest.mark.require_docker_in_docker
228+
@pytest.mark.no_xdist
228229
@unittest.skipUnless(
229230
platform.system() == "Linux",
230231
"Test runs only on Linux due to lack of support, as yet, for nested "

sdks/python/apache_beam/ml/rag/ingestion/milvus_search_it_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ def drop_collection(client: MilvusClient, collection_name: str):
162162

163163

164164
@pytest.mark.require_docker_in_docker
165+
@pytest.mark.no_xdist
165166
@unittest.skipIf(not PYMILVUS_AVAILABLE, 'pymilvus is not installed.')
166167
@unittest.skipUnless(
167168
platform.system() == "Linux",

sdks/python/apache_beam/ml/rag/test_utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ def __init__( # pylint: disable=bad-super-call
113113
self.with_bind_ports(service_container_port, service_host_port)
114114
self.with_bind_ports(healthcheck_container_port, healthcheck_host_port)
115115
self.cmd = "milvus run standalone"
116+
self.with_command(self.cmd)
116117

117118
# Set environment variables needed for Milvus.
118119
envs = {

0 commit comments

Comments
 (0)