Skip to content

Commit 0dfdf46

Browse files
committed
refactor: remove disk provisioned IOPS and throughput arguments from WorkerOptions
1 parent 2cfb771 commit 0dfdf46

2 files changed

Lines changed: 2 additions & 25 deletions

File tree

sdks/python/apache_beam/options/pipeline_options.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1405,24 +1405,6 @@ def _add_argparse_args(cls, parser):
14051405
dest='disk_type',
14061406
default=None,
14071407
help=('Specifies what type of persistent disk should be used.'))
1408-
parser.add_argument(
1409-
'--disk_provisioned_iops',
1410-
type=int,
1411-
default=None,
1412-
dest='disk_provisioned_iops',
1413-
help=(
1414-
'The provisioned IOPS of the disk. If not set, the Dataflow service'
1415-
' will choose a reasonable default.'),
1416-
)
1417-
parser.add_argument(
1418-
'--disk_provisioned_throughput_mibps',
1419-
type=int,
1420-
default=None,
1421-
dest='disk_provisioned_throughput_mibps',
1422-
help=(
1423-
'The provisioned throughput of the disk in MiB/s. If not set, the'
1424-
' Dataflow service will choose a reasonable default.'),
1425-
)
14261408
parser.add_argument(
14271409
'--worker_region',
14281410
default=None,

sdks/python/apache_beam/options/pipeline_options_test.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626

2727
import hamcrest as hc
2828
import mock
29+
from parameterized import parameterized
30+
2931
from apache_beam.options.pipeline_options import CrossLanguageOptions
3032
from apache_beam.options.pipeline_options import DebugOptions
3133
from apache_beam.options.pipeline_options import GoogleCloudOptions
@@ -41,7 +43,6 @@
4143
from apache_beam.options.value_provider import StaticValueProvider
4244
from apache_beam.transforms.display import DisplayData
4345
from apache_beam.transforms.display_test import DisplayDataItemMatcher
44-
from parameterized import parameterized
4546

4647
_LOGGER = logging.getLogger(__name__)
4748

@@ -443,18 +444,12 @@ def test_worker_options(self):
443444
'abc',
444445
'--disk_type',
445446
'def',
446-
'--disk_provisioned_iops',
447-
'4000',
448-
'--disk_provisioned_throughput_mibps',
449-
'200',
450447
'--element_processing_timeout_minutes',
451448
'10',
452449
])
453450
worker_options = options.view_as(WorkerOptions)
454451
self.assertEqual(worker_options.machine_type, 'abc')
455452
self.assertEqual(worker_options.disk_type, 'def')
456-
self.assertEqual(worker_options.disk_provisioned_iops, 4000)
457-
self.assertEqual(worker_options.disk_provisioned_throughput_mibps, 200)
458453
self.assertEqual(worker_options.element_processing_timeout_minutes, 10)
459454

460455
options = PipelineOptions(

0 commit comments

Comments
 (0)