Skip to content

Commit 1d42cd3

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 6a7d0e5 commit 1d42cd3

6 files changed

Lines changed: 13 additions & 13 deletions

File tree

sdks/java/extensions/sbe/src/test/java/org/apache/beam/sdk/extensions/sbe/SbeLogicalTypesTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void testTzTimestamp() {
5959

6060
@Test
6161
public void testUtcTimeOnly() {
62-
LocalTime time = LocalTime.now(ZoneId.systemDefault());
62+
LocalTime time = LocalTime.now(ZoneId.of("UTC"));
6363
UTCTimeOnly timeOnly = new UTCTimeOnly();
6464

6565
LocalTime afterConversions = timeOnly.toInputType(timeOnly.toBaseType(time));
@@ -79,7 +79,7 @@ public void testTzTimeOnly() {
7979

8080
@Test
8181
public void testUtcDateOnly() {
82-
LocalDate date = LocalDate.now(ZoneId.systemDefault());
82+
LocalDate date = LocalDate.now(ZoneId.of("UTC"));
8383
UTCDateOnly dateOnly = new UTCDateOnly();
8484

8585
LocalDate afterConversions = dateOnly.toInputType(dateOnly.toBaseType(date));
@@ -89,7 +89,7 @@ public void testUtcDateOnly() {
8989

9090
@Test
9191
public void testLocalMktDate() {
92-
LocalDate date = LocalDate.now(ZoneId.systemDefault());
92+
LocalDate date = LocalDate.now(ZoneId.of("UTC"));
9393
LocalMktDate localMktDate = new LocalMktDate();
9494

9595
LocalDate afterConversions = localMktDate.toInputType(localMktDate.toBaseType(date));

sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/schema/BeamSqlRowCoderTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ public void encodeAndDecode() throws Exception {
7171
1.1,
7272
BigDecimal.ZERO,
7373
"hello",
74-
LocalTime.now(ZoneId.systemDefault()),
75-
LocalDate.now(ZoneId.systemDefault()),
76-
LocalDateTime.now(ZoneId.systemDefault()),
74+
LocalTime.now(ZoneId.of("UTC")),
75+
LocalDate.now(ZoneId.of("UTC")),
76+
LocalDateTime.now(ZoneId.of("UTC")),
7777
DateTime.now().toInstant(),
7878
true)
7979
.build();

sdks/java/io/azure/src/test/java/org/apache/beam/sdk/io/azure/blobstore/AzureBlobStoreFileSystemTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public void beforeClass() {
112112
when(mockedBlobClient.getProperties()).thenReturn(mockedProperties);
113113
when(mockedProperties.getBlobSize()).thenReturn(Long.valueOf(1));
114114
when(mockedProperties.getLastModified())
115-
.thenReturn(OffsetDateTime.now(java.time.ZoneId.systemDefault()));
115+
.thenReturn(OffsetDateTime.now(java.time.ZoneOffset.UTC));
116116
when(mockedContainerClient.listBlobs(any(ListBlobsOptions.class), any(Duration.class)))
117117
.thenReturn(mockedPagedIterable);
118118
when(mockedContainerClient.listBlobsByHierarchy(any(String.class)))

sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTestUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ static long refreshIndexAndGetCurrentNumDocs(
343343
static List<String> createDocuments(long numDocs, InjectionMode injectionMode) {
344344

345345
ArrayList<String> data = new ArrayList<>();
346-
LocalDateTime baseDateTime = LocalDateTime.now(java.time.ZoneId.systemDefault());
346+
LocalDateTime baseDateTime = LocalDateTime.now(java.time.ZoneOffset.UTC);
347347
for (int i = 0; i < numDocs; i++) {
348348
int index = i % FAMOUS_SCIENTISTS.length;
349349
// insert 2 malformed documents

sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BeamRowToStorageApiProtoTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,9 +253,9 @@ public class BeamRowToStorageApiProtoTest {
253253
.withFieldValue("arrayValue", ImmutableList.of("one", "two", "red", "blue"))
254254
.withFieldValue("arrayNullValue", null)
255255
.withFieldValue("iterableValue", ImmutableList.of("blue", "red", "two", "one"))
256-
.withFieldValue("sqlDateValue", LocalDate.now(ZoneId.systemDefault()))
257-
.withFieldValue("sqlTimeValue", LocalTime.now(ZoneId.systemDefault()))
258-
.withFieldValue("sqlDatetimeValue", LocalDateTime.now(ZoneId.systemDefault()))
256+
.withFieldValue("sqlDateValue", LocalDate.now(ZoneId.of("UTC")))
257+
.withFieldValue("sqlTimeValue", LocalTime.now(ZoneId.of("UTC")))
258+
.withFieldValue("sqlDatetimeValue", LocalDateTime.now(ZoneId.of("UTC")))
259259
.withFieldValue("sqlTimestampValue", java.time.Instant.now().plus(123, ChronoUnit.MICROS))
260260
.withFieldValue("enumValue", TEST_ENUM.valueOf("RED"))
261261
.build();

sdks/java/io/influxdb/src/test/java/org/apache/beam/sdk/io/influxdb/GenerateData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ static List<String> getMetric(String metric, int number) {
4040
m.addField("field2", random.nextInt(100));
4141
LocalDateTime time =
4242
LocalDateTime.of(
43-
LocalDate.now(ZoneId.systemDefault()),
43+
LocalDate.now(ZoneId.of("America/Los_Angeles")),
4444
LocalTime.of(
4545
random.nextInt(24),
4646
random.nextInt(60),
@@ -64,7 +64,7 @@ static List<String> getMultipleMetric(List<String> metrics, int number) {
6464
m.addField("field2", random.nextInt(100));
6565
LocalDateTime time =
6666
LocalDateTime.of(
67-
LocalDate.now(ZoneId.systemDefault()),
67+
LocalDate.now(ZoneId.of("America/Los_Angeles")),
6868
LocalTime.of(
6969
random.nextInt(24),
7070
random.nextInt(60),

0 commit comments

Comments
 (0)