Skip to content

Commit 239824b

Browse files
committed
Fix grpc setup timeout
1 parent 7977ec2 commit 239824b

2 files changed

Lines changed: 1 addition & 23 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"comment": "Modify this file in a trivial way to cause this test suite to run",
3-
"revision": 4
3+
"revision": 5
44
}

sdks/python/apache_beam/ml/rag/test_utils.py

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -137,27 +137,6 @@ class MilvusTestHelpers:
137137
# https://milvus.io/docs/release_notes.md or PyPI at
138138
# https://pypi.org/project/pymilvus/ for version compatibility.
139139
# Example: Milvus v2.6.0 requires pymilvus==2.6.0 (exact match required).
140-
@staticmethod
141-
def _wait_for_milvus_grpc(uri: str) -> None:
142-
"""Wait until Milvus accepts RPCs.
143-
144-
Docker may report started before gRPC is ready.
145-
"""
146-
def list_collections_probe():
147-
client = MilvusClient(uri=uri)
148-
try:
149-
client.list_collections()
150-
finally:
151-
client.close()
152-
153-
retry_with_backoff(
154-
list_collections_probe,
155-
max_retries=25,
156-
retry_delay=2.0,
157-
retry_backoff_factor=1.2,
158-
operation_name="Milvus client connection after container start",
159-
exception_types=(MilvusException, ))
160-
161140
@staticmethod
162141
def start_db_container(
163142
image="milvusdb/milvus:v2.5.10",
@@ -188,7 +167,6 @@ def start_db_container(
188167
host = running_container.get_container_host_ip()
189168
port = running_container.get_exposed_port(service_container_port)
190169
info = VectorDBContainerInfo(running_container, host, port)
191-
MilvusTestHelpers._wait_for_milvus_grpc(info.uri)
192170
_LOGGER.info(
193171
"milvus db container started successfully on %s.", info.uri)
194172
break

0 commit comments

Comments
 (0)