Skip to content

Commit 2584b11

Browse files
nikitagrover19Nikita Grover
authored andcommitted
Update pubsub_integration_test.py
1 parent a94d896 commit 2584b11

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

sdks/python/apache_beam/io/gcp/pubsub_integration_test.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -308,16 +308,18 @@ def test_batch_write_with_attributes(self):
308308
@pytest.mark.it_postcommit
309309
def test_batch_write_with_ordering_key(self):
310310
"""Test WriteToPubSub in batch mode with ordering keys.
311-
This test only applies to the Direct Runner. The ordering key fix in
312-
_PubSubWriteDoFn._flush() does not apply to Dataflow, which uses its own
313-
internal implementation. Dataflow users should use the XLang WriteToPubSub
311+
Dataflow Native PubSub Sink does not support ordering_key, therefore this
312+
test only applies to runners that use Beam's Python WriteToPubSub Sink.
313+
To use ordering_key, Dataflow users should use the XLang WriteToPubSub
314314
path instead.
315315
"""
316316
if self.runner_name == 'TestDataflowRunner':
317317
self.skipTest(
318-
'Ordering key support via _flush() is not applicable to Dataflow. '
319-
'Use the XLang WriteToPubSub path for ordering key support on '
320-
'Dataflow.')
318+
'Dataflow Native PubSub Sink does not support ordering_key '
319+
'(see https://github.com/apache/beam/issues/36201), therefore '
320+
'this test only applies to runners that use Beam\'s Python '
321+
'WriteToPubSub Sink. To use ordering_key, Dataflow users should '
322+
'use the XLang WriteToPubSub path instead.')
321323

322324
from apache_beam.options.pipeline_options import PipelineOptions
323325
from apache_beam.options.pipeline_options import StandardOptions

0 commit comments

Comments
 (0)