Skip to content

Commit 33ad247

Browse files
committed
Add TODOs
1 parent e428be2 commit 33ad247

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

sdks/python/apache_beam/runners/portability/portable_runner_test.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import inspect
2020
import logging
21+
import os
2122
import socket
2223
import subprocess
2324
import sys
@@ -328,16 +329,16 @@ class PortableRunnerTestWithSubprocessesAndMultiWorkers(
328329
PortableRunnerTestWithSubprocesses):
329330
_use_subprocesses = True
330331

332+
# TODO(https://github.com/grpc/grpc/issues/37710): Remove once fixed.
331333
@classmethod
332334
def setUpClass(cls):
333-
import os
334335
cls._old_fork_support = os.environ.get('GRPC_ENABLE_FORK_SUPPORT')
335336
os.environ['GRPC_ENABLE_FORK_SUPPORT'] = 'false'
336337
super().setUpClass()
337338

339+
# TODO(https://github.com/grpc/grpc/issues/37710): Remove once fixed.
338340
@classmethod
339341
def tearDownClass(cls):
340-
import os
341342
if cls._old_fork_support is None:
342343
os.environ.pop('GRPC_ENABLE_FORK_SUPPORT', None)
343344
else:

sdks/python/apache_beam/utils/subprocess_server_test.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,17 @@
3737

3838

3939
class JavaJarServerTest(unittest.TestCase):
40+
41+
# TODO(https://github.com/grpc/grpc/issues/37710): Remove once fixed.
4042
@classmethod
4143
def setUpClass(cls):
42-
import os
4344
cls._old_fork_support = os.environ.get('GRPC_ENABLE_FORK_SUPPORT')
4445
os.environ['GRPC_ENABLE_FORK_SUPPORT'] = 'false'
4546
super().setUpClass()
4647

48+
# TODO(https://github.com/grpc/grpc/issues/37710): Remove once fixed.
4749
@classmethod
4850
def tearDownClass(cls):
49-
import os
5051
if cls._old_fork_support is None:
5152
os.environ.pop('GRPC_ENABLE_FORK_SUPPORT', None)
5253
else:

0 commit comments

Comments
 (0)