Skip to content

Commit 4175438

Browse files
Apply suggestions from code review
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 385636c commit 4175438

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowWorkerLoggingOptions.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
/**
3131
* Options that are used to control logging configuration on the Dataflow worker.
3232
*
33-
* <p> Some options in this interface are no longer the source of truth for worker logging configuration
33+
* <p>Some options in this interface are no longer the source of truth for worker logging configuration.
3434
* Consider using the corresponding options within {@link org.apache.beam.sdk.options.SdkHarnessOptions} to ensure
3535
* compatibility with other runners.
3636
*/
@@ -57,11 +57,12 @@ enum Level {
5757
TRACE
5858
}
5959

60-
/** This option controls the default log level of all loggers without a log level override.
60+
/**
61+
* This option controls the default log level of all loggers without a log level override.
6162
*
62-
* @deprecated Prefer defaultSdkHarnessLogLevel within org.apache.beam.sdk.options.SdkHarnessOptions
63+
* @deprecated Prefer {@link org.apache.beam.sdk.options.SdkHarnessOptions#getDefaultSdkHarnessLogLevel()}
6364
* which works across runners.
64-
* */
65+
*/
6566
@Description("Controls the default log level of all loggers without a log level override.")
6667
@Default.Enum("INFO")
6768
@Deprecated
@@ -108,7 +109,7 @@ enum Level {
108109
* defaultWorkerLogLevel} or if a {@code System.out} override is specified via {@link
109110
* #getWorkerLogLevelOverrides workerLogLevelOverrides}.
110111
*
111-
* @deprecated Prefer using org.apache.beam.sdk.options.SdkHarnessOptions.sdkHarnessLogLevelOverrides to override the
112+
* @deprecated Prefer using {@link org.apache.beam.sdk.options.SdkHarnessOptions#getSdkHarnessLogLevelOverrides()} to override the
112113
* 'System.out' logger as this works across runners.
113114
*/
114115
@Description(
@@ -128,7 +129,7 @@ enum Level {
128129
* defaultWorkerLogLevel} or if a {@code System.err} override is specified via {@link
129130
* #getWorkerLogLevelOverrides workerLogLevelOverrides}.
130131
*
131-
* @deprecated Prefer using org.apache.beam.sdk.options.SdkHarnessOptions.sdkHarnessLogLevelOverrides to override the
132+
* @deprecated Prefer using {@link org.apache.beam.sdk.options.SdkHarnessOptions#getSdkHarnessLogLevelOverrides()} to override the
132133
* 'System.err' logger as this works across runners.
133134
*/
134135
@Description(
@@ -150,7 +151,7 @@ enum Level {
150151
* per {@link Class}, {@link Package}, or name basis. If used from the command line, the expected
151152
* format is {"Name":"Level",...}, further details on {@link WorkerLogLevelOverrides#from}.
152153
*
153-
* @deprecated Prefer using org.apache.beam.sdk.options.SdkHarnessOptions.sdkHarnessLogLevelOverrides which works
154+
* @deprecated Prefer using {@link org.apache.beam.sdk.options.SdkHarnessOptions#getSdkHarnessLogLevelOverrides()} which works
154155
* across runners.
155156
*/
156157
@Description(

0 commit comments

Comments
 (0)