enable Slf4jFormatShouldBeConst

Author: stankiewicz

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

@@ -1562,7 +1562,6 @@ class BeamModulePlugin implements Plugin<Project> {
             "MutablePublicArray",
             "NonCanonicalType",
             "ProtectedMembersInFinalClass",
-            "Slf4jFormatShouldBeConst",
             "Slf4jSignOnlyFormat",
             "StaticAssignmentInConstructor",
             "ThreadPriorityCheck",

it/common/src/main/java/org/apache/beam/it/common/utils/IORedirectUtil.java

@@ -41,7 +41,7 @@ public static void redirectLinesLog(InputStream inputStream, Logger log) {
 
                 String line;
                 while ((line = bis.readLine()) != null) {
-                  log.info(line);
+                  log.info("{}", line);
                 }
               } catch (Exception e) {
                 log.error("Error redirecting stream", e);

it/jdbc/src/main/java/org/apache/beam/it/jdbc/AbstractJDBCResourceManager.java

@@ -210,7 +210,7 @@ public boolean write(String tableName, List<Map<String, Object>> rows)
         sql.append(String.join(",", valueList)).append(")");
 
         try {
-          LOG.info("Running SQL statement: " + sql);
+          LOG.info("Running SQL statement: {}", sql);
           stmt.executeUpdate(sql.toString());
         } catch (SQLException e) {
           throw new JDBCResourceManagerException(

runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsLogger.java

@@ -61,7 +61,7 @@ public void tryLoggingMetrics(
         long currentTimeMillis = System.currentTimeMillis();
         long lastReported = lastReportedMillis.get();
         if (currentTimeMillis - lastReported > minimumLoggingFrequencyMillis) {
-          LOG.info(generateLogMessage(header, allowedMetricUrns, lastReported));
+          LOG.info("{}", generateLogMessage(header, allowedMetricUrns, lastReported));
           lastReportedMillis.set(currentTimeMillis);
         }
       } finally {

runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/SimpleExecutionState.java

@@ -151,7 +151,7 @@ public String getLullMessage(Thread trackedThread, Duration millis) {
 
   @Override
   public void reportLull(Thread trackedThread, long millis) {
-    LOG.warn(getLullMessage(trackedThread, Duration.millis(millis)));
+    LOG.warn("{}", getLullMessage(trackedThread, Duration.millis(millis)));
   }
 
   @VisibleForTesting

runners/direct-java/src/main/java/org/apache/beam/runners/direct/DoFnLifecycleManagerRemovingTransformEvaluator.java

@@ -84,7 +84,7 @@ private void onException(Exception e, String msg) {
       if (removalException instanceof InterruptedException) {
         Thread.currentThread().interrupt();
       }
-      LOG.error(msg, removalException);
+      LOG.error("{}", msg, removalException);
       e.addSuppressed(removalException);
     }
   }

runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPipelineTranslator.java

@@ -133,7 +133,7 @@ public void visitPrimitiveTransform(TransformHierarchy.Node node) {
 
     if (translator == null || !applyCanTranslate(transform, node, translator)) {
       String transformUrn = PTransformTranslation.urnForTransform(transform);
-      LOG.info(transformUrn);
+      LOG.info("{}", transformUrn);
       throw new UnsupportedOperationException(
           "The transform " + transformUrn + " is currently not supported.");
     }

runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/FnApiControlClientPoolService.java

@@ -117,7 +117,7 @@ public void getProcessBundleDescriptor(
       String msg =
           String.format("ProcessBundleDescriptor with id %s not found", bundleDescriptorId);
       responseObserver.onError(new StatusException(Status.NOT_FOUND.withDescription(msg)));
-      LOG.error(msg);
+      LOG.error("{}", msg);
     } else {
       responseObserver.onNext(descriptor);
       responseObserver.onCompleted();

runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/logging/Slf4jLogWriter.java

@@ -35,6 +35,7 @@ public static LogWriter getDefault() {
   private Slf4jLogWriter() {}
 
   @Override
+  @SuppressWarnings("Slf4jFormatShouldBeConst")
   public void log(LogEntry entry) {
     Logger log;
     String location = entry.getLogLocation();

runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/status/WorkerStatusClient.java

@@ -141,9 +141,9 @@ public void onNext(WorkerStatusResponse response) {
         future.complete(response);
       } else {
         LOG.warn(
-            String.format(
-                "Received response for status with unknown response id %s and status %s",
-                response.getId(), response.getStatusInfo()));
+            "Received response for status with unknown response id {} and status {}",
+            response.getId(),
+            response.getStatusInfo());
       }
     }