Skip to content

Commit 562d333

Browse files
committed
fix iceberg unit test
1 parent 3c827e9 commit 562d333

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"comment": "Modify this file in a trivial way to cause this test suite to run ",
3-
"modification": 3
3+
"modification": 4
44
}

sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/FilterUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ private static Object convertLiteral(SqlLiteral literal, String field, TypeID ty
340340
return literal.getValueAs(String.class);
341341
case DATE:
342342
LocalDate date;
343-
if (SqlTypeName.STRING_TYPES.contains(typeName)) {
343+
if (SqlTypeName.STRING_TYPES.contains(typeName) || SqlTypeName.UNKNOWN.equals(typeName)) {
344344
date = LocalDate.parse(literal.getValueAs(String.class));
345345
} else if (SqlTypeName.DATE.equals(typeName)) {
346346
DateString dateValue = literal.getValueAs(DateString.class);
@@ -351,7 +351,7 @@ private static Object convertLiteral(SqlLiteral literal, String field, TypeID ty
351351
return DateTimeUtil.daysFromDate(date);
352352
case TIME:
353353
LocalTime time;
354-
if (SqlTypeName.STRING_TYPES.contains(typeName)) {
354+
if (SqlTypeName.STRING_TYPES.contains(typeName) || SqlTypeName.UNKNOWN.equals(typeName)) {
355355
time = LocalTime.parse(literal.getValueAs(String.class));
356356
} else if (SqlTypeName.TIME.equals(typeName)) {
357357
TimeString timeString = literal.getValueAs(TimeString.class);
@@ -362,7 +362,7 @@ private static Object convertLiteral(SqlLiteral literal, String field, TypeID ty
362362
return DateTimeUtil.microsFromTime(time);
363363
case TIMESTAMP:
364364
LocalDateTime datetime;
365-
if (SqlTypeName.STRING_TYPES.contains(typeName)) {
365+
if (SqlTypeName.STRING_TYPES.contains(typeName) || SqlTypeName.UNKNOWN.equals(typeName)) {
366366
String value = literal.getValueAs(String.class);
367367
datetime = getLocalDateTime(value);
368368
} else if (SqlTypeName.DATE.equals(typeName)) {

0 commit comments

Comments
 (0)