Skip to content

Commit 60b5950

Browse files
committed
Loose withCloseTimeout to fix flaky integration test; fix label
1 parent aa7f7e8 commit 60b5950

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ public interface JmsIOITOptions extends IOTestPipelineOptions, StreamingOptions
146146
@Rule public transient TestPipeline pipelineWrite = TestPipeline.create();
147147
@Rule public transient TestPipeline pipelineRead = TestPipeline.create();
148148

149-
@Parameterized.Parameters(name = "with client class {3}")
149+
@Parameterized.Parameters(name = "with client class {2}")
150150
public static Collection<Object[]> connectionFactories() {
151151
return ImmutableList.of(
152152
new Object[] {"vm://localhost", "jms.sendAcksAsync=false", ActiveMQConnectionFactory.class},
@@ -304,9 +304,9 @@ private PipelineResult readMessages(JmsIO.AcknowledgeMode acknowledgeMode, Strin
304304
JmsIO.Read<String> jmsIORead =
305305
JmsIO.<String>readMessage()
306306
.withAcknowledgeMode(acknowledgeMode)
307-
// Decrease withCloseTimeout to be smaller than pipeline runtime. Direct runner randomly
307+
// Decrease withCloseTimeout to be smaller than pipeline timeout. Direct runner randomly
308308
// closes reader causing cached pending consumer hanging until closeTimeout
309-
.withCloseTimeout(Duration.standardSeconds(5));
309+
.withCloseTimeout(Duration.standardSeconds(10));
310310
if (pipelineRead.getOptions().as(JmsIOITOptions.class).getUseConnectionFactoryProviderFn()) {
311311
jmsIORead =
312312
jmsIORead.withConnectionFactoryProviderFn(

sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ private static TextMessage createTextMessage(Session session, long messageIndex)
152152
RetryConfiguration.create(1, Duration.standardSeconds(1), null);
153153
@Rule public final transient TestPipeline pipeline = TestPipeline.create();
154154

155-
@Parameterized.Parameters(name = "with client class {3}")
155+
@Parameterized.Parameters(name = "with client class {2}")
156156
public static Collection<Object[]> connectionFactories() {
157157
return Arrays.asList(
158158
new Object[] {"vm://localhost", "jms.sendAcksAsync=false", ActiveMQConnectionFactory.class},

0 commit comments

Comments
 (0)