Skip to content

Commit 7f64dec

Browse files
committed
Revert "Fix post commit xlang jdbcio test failure (#35428)"
This reverts commit 6ac5009.
1 parent 7256a14 commit 7f64dec

3 files changed

Lines changed: 2 additions & 12 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"comment": "Modify this file in a trivial way to cause this test suite to run.",
3-
"modification": 2
3+
"modification": 3
44
}
55

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"comment": "Modify this file in a trivial way to cause this test suite to run",
3-
"modification": 7
3+
"modification": 9
44
}

sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@
3636
from apache_beam.testing.test_pipeline import TestPipeline
3737
from apache_beam.testing.util import assert_that
3838
from apache_beam.testing.util import equal_to
39-
from apache_beam.typehints.schemas import LogicalType
40-
from apache_beam.typehints.schemas import MillisInstant
4139
from apache_beam.utils.timestamp import Timestamp
4240

4341
# pylint: disable=wrong-import-order, wrong-import-position, ungrouped-imports
@@ -241,10 +239,6 @@ def test_xlang_jdbc_write_read(self, database):
241239

242240
config = self.jdbc_configs[database]
243241

244-
# Register MillisInstant logical type to override the mapping from Timestamp
245-
# originally handled by MicrosInstant.
246-
LogicalType.register_logical_type(MillisInstant)
247-
248242
with TestPipeline() as p:
249243
p.not_use_test_runner_api = True
250244
_ = (
@@ -355,10 +349,6 @@ def custom_row_equals(expected, actual):
355349
classpath=config['classpath'],
356350
))
357351

358-
# Register MillisInstant logical type to override the mapping from Timestamp
359-
# originally handled by MicrosInstant.
360-
LogicalType.register_logical_type(MillisInstant)
361-
362352
# Run read pipeline with custom schema
363353
with TestPipeline() as p:
364354
p.not_use_test_runner_api = True

0 commit comments

Comments
 (0)