Commit 8a4328a
committed
fix: use global coder registry; Pipeline has no coder_registry attr
beam_PreCommit_Python_Coverage CI on PR 38724 surfaced
``AttributeError: 'Pipeline' object has no attribute 'coder_registry'``
from the previous commit's attempt to register the source-declared
output coder against a pipeline-scoped registry. Beam's Python
``Pipeline`` has no such attribute today; the global ``coders.registry``
is the only available knob, matching the pattern used by ``BoundedSource``
at iobase.py:938. Reverting to ``coders.registry.register_coder``.
The cross-pipeline side effect that the pipeline-scoped attempt was
trying to avoid (a registration persists for the process lifetime and
may affect concurrent pipelines that use the same element type) is now
documented as a known limitation tracked under #19137 W2.
42/42 unbounded_source_test, 16/16 iobase_test.1 parent 0753268 commit 8a4328a
1 file changed
Lines changed: 10 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
779 | 779 | | |
780 | 780 | | |
781 | 781 | | |
782 | | - | |
| 782 | + | |
783 | 783 | | |
784 | 784 | | |
785 | | - | |
786 | | - | |
787 | | - | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
788 | 792 | | |
789 | 793 | | |
790 | 794 | | |
791 | 795 | | |
792 | 796 | | |
793 | 797 | | |
794 | | - | |
795 | | - | |
| 798 | + | |
796 | 799 | | |
797 | 800 | | |
798 | 801 | | |
799 | 802 | | |
800 | 803 | | |
801 | | - | |
| 804 | + | |
802 | 805 | | |
803 | 806 | | |
804 | 807 | | |
| |||
0 commit comments