Skip to content

Commit 8a5e0af

Browse files
committed
Add import guards
1 parent b009ad8 commit 8a5e0af

1 file changed

Lines changed: 13 additions & 8 deletions

File tree

sdks/python/apache_beam/ml/rag/ingestion/milvus_search_it_test.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,6 @@
2222
from typing import cast
2323

2424
import pytest
25-
from pymilvus import CollectionSchema
26-
from pymilvus import DataType
27-
from pymilvus import FieldSchema
28-
from pymilvus import MilvusClient
29-
from pymilvus.exceptions import MilvusException
30-
from pymilvus.milvus_client import IndexParams
3125

3226
import apache_beam as beam
3327
from apache_beam.ml.rag.ingestion.jdbc_common import WriteConfig
@@ -41,11 +35,21 @@
4135
from apache_beam.ml.rag.utils import unpack_dataclass_with_kwargs
4236
from apache_beam.testing.test_pipeline import TestPipeline
4337

38+
# pylint: disable=wrong-import-order, wrong-import-position, ungrouped-imports
4439
try:
40+
from pymilvus import CollectionSchema
41+
from pymilvus import DataType
42+
from pymilvus import FieldSchema
43+
from pymilvus import MilvusClient
44+
45+
from pymilvus.exceptions import MilvusException
46+
from pymilvus.milvus_client import IndexParams
4547
from apache_beam.ml.rag.ingestion.milvus_search import MilvusVectorWriterConfig
4648
from apache_beam.ml.rag.ingestion.milvus_search import MilvusWriteConfig
47-
except ImportError as e:
48-
raise unittest.SkipTest(f'Milvus dependencies not installed: {str(e)}')
49+
PYMILVUS_AVAILABLE = True
50+
except ImportError:
51+
PYMILVUS_AVAILABLE = False
52+
# pylint: enable=wrong-import-order, wrong-import-position, ungrouped-imports
4953

5054

5155
def _construct_index_params():
@@ -158,6 +162,7 @@ def drop_collection(client: MilvusClient, collection_name: str):
158162

159163

160164
@pytest.mark.require_docker_in_docker
165+
@unittest.skipIf(not PYMILVUS_AVAILABLE, 'pymilvus is not installed.')
161166
@unittest.skipUnless(
162167
platform.system() == "Linux",
163168
"Test runs only on Linux due to lack of support, as yet, for nested "

0 commit comments

Comments
 (0)