Enable error_prone UnnecessaryLongToIntConversion check (#37783)

Author: stankiewicz

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

@@ -1569,7 +1569,6 @@ class BeamModulePlugin implements Plugin<Project> {
             "NullableTypeParameter",
             "NullableWildcard",
             "SuperCallToObjectMethod",
-            "UnnecessaryLongToIntConversion",
             "UnusedVariable",
             // intended suppressions emerged in newer protobuf versions
             // For backward compatibility. Public method checked in before this check impl

runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java

@@ -181,7 +181,7 @@ private StreamingGlobalConfig createPipelineConfig(StreamingConfigTask config) {
     if (config.getMaxWorkItemCommitBytes() != null
         && config.getMaxWorkItemCommitBytes() > 0
         && config.getMaxWorkItemCommitBytes() <= Integer.MAX_VALUE) {
-      operationalLimits.setMaxWorkItemCommitBytes(config.getMaxWorkItemCommitBytes().intValue());
+      operationalLimits.setMaxWorkItemCommitBytes(config.getMaxWorkItemCommitBytes());
     }
 
     if (config.getOperationalLimits() != null) {

runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaRunnerWithTransformMetrics.java

@@ -245,7 +245,7 @@ public void testSamzaInputAndOutputMetricOp() {
     // Latency must be positive
     assertTrue(latency.getSnapshot().getAverage() > 0);
     // Cache size must be 0
-    assertEquals(0, cacheSize.getValue().intValue());
+    assertEquals(0L, cacheSize.getValue().longValue());
   }
 
   @Test
@@ -318,6 +318,6 @@ public void testSamzaInputAndOutputGBKMetricOp() {
     // Latency must be positive
     assertTrue(latency.getSnapshot().getAverage() > 0);
     // Cache size must be 0
-    assertEquals(0, cacheSize.getValue().intValue());
+    assertEquals(0L, cacheSize.getValue().longValue());
   }
 }

runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaTransformMetricsRegistry.java

@@ -102,7 +102,7 @@ public void testSamzaTransformMetricsRegistryForNonShuffleOperators() {
             .get("dummy-pvalue.out")
             .containsKey(watermarkMessage.getTimestamp()));
     // Cache size must be 0
-    assertEquals(0, cacheSize.getValue().intValue());
+    assertEquals(0L, cacheSize.getValue().longValue());
   }
 
   @Test
@@ -186,6 +186,6 @@ public Instant maxTimestamp() {
     // Check the latency metric is same
     assertTrue(1000 == latency.getSnapshot().getAverage());
     // Cache size must be 0
-    assertEquals(0, cacheSize.getValue().intValue());
+    assertEquals(0L, cacheSize.getValue().longValue());
   }
 }

sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOIT.java

@@ -188,7 +188,7 @@ public void testReadFromSimpleTopic() throws PulsarClientException {
         break;
       }
     }
-    assertEquals(inputsMock.size(), (int) recordsCount);
+    assertEquals(inputsMock.size(), recordsCount);
   }
 
   @Test