Skip to content

Commit 8f85812

Browse files
committed
Re-enable prism on pipelines with unsafe triggers when calling DirectRunner.
1 parent 7b21ecd commit 8f85812

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

sdks/python/apache_beam/runners/direct/direct_runner.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -121,14 +121,8 @@ def accept(self, pipeline, is_interactive):
121121
all_options = options.get_all_options()
122122
self.supported_by_prism_runner = True
123123
# TODO(https://github.com/apache/beam/issues/33623): Prism currently
124-
# double fires on AfterCount trigger, once appropriately, and once
125-
# incorrectly at the end of the window. This if condition could be
126-
# more targeted, but for now we'll just ignore all unsafe triggers.
127-
if pipeline.allow_unsafe_triggers:
128-
self.supported_by_prism_runner = False
129-
# TODO(https://github.com/apache/beam/issues/33623): Prism currently
130124
# does not support interactive mode
131-
elif is_in_ipython() or is_interactive:
125+
if is_in_ipython() or is_interactive:
132126
self.supported_by_prism_runner = False
133127
# TODO(https://github.com/apache/beam/issues/33623): Prism currently
134128
# does not support the update compat flag

0 commit comments

Comments
 (0)