Skip to content

Commit a9e88ef

Browse files
committed
address review comments
1 parent 603b681 commit a9e88ef

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,10 @@ public ResourceId apply(@Nonnull Metadata input) {
408408
* <p>- Number of directory<=100, report directory names (one level up);
409409
*
410410
* <p>- Otherwise, report top level only.
411+
*
412+
* <p>For internal use only by Beam-provided file-based connectors; not a stable public API.
411413
*/
414+
@Internal
412415
public static void reportSourceLineage(List<ResourceId> resourceIds) {
413416
final int maxLineageTargets = 100;
414417
if (resourceIds.size() <= maxLineageTargets) {

sdks/java/io/hadoop-file-system/src/main/java/org/apache/beam/sdk/io/hdfs/HadoopFileSystem.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -337,11 +337,6 @@ protected String getScheme() {
337337
return scheme;
338338
}
339339

340-
@Override
341-
protected void reportLineage(HadoopResourceId resourceId, Lineage lineage) {
342-
reportLineage(resourceId, lineage, LineageLevel.FILE);
343-
}
344-
345340
@Override
346341
protected void reportLineage(HadoopResourceId resourceId, Lineage lineage, LineageLevel level) {
347342
URI uri = resourceId.toPath().toUri();

sdks/java/io/hadoop-file-system/src/test/java/org/apache/beam/sdk/io/hdfs/HadoopFileSystemTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import java.util.Collections;
4141
import java.util.List;
4242
import java.util.Objects;
43+
import org.apache.beam.sdk.io.FileSystem;
4344
import org.apache.beam.sdk.io.FileSystems;
4445
import org.apache.beam.sdk.io.TextIO;
4546
import org.apache.beam.sdk.io.fs.CreateOptions.StandardCreateOptions;
@@ -496,7 +497,7 @@ public void testReportLineage() {
496497
private void verifyLineage(String uri, List<String> expected) {
497498
HadoopResourceId resourceId = new HadoopResourceId(URI.create(uri));
498499
Lineage mockLineage = mock(Lineage.class);
499-
fileSystem.reportLineage(resourceId, mockLineage);
500+
fileSystem.reportLineage(resourceId, mockLineage, FileSystem.LineageLevel.FILE);
500501
verify(mockLineage, times(1)).add("hdfs", expected, "/");
501502
}
502503

0 commit comments

Comments
 (0)