Skip to content

Commit b39a73f

Browse files
committed
address another gemini comment
1 parent a3bb23d commit b39a73f

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

  • sdks/python/apache_beam/dataframe

sdks/python/apache_beam/dataframe/io.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -680,25 +680,25 @@ def __init__(
680680
self.binary = binary
681681

682682
def expand(self, pcoll):
683-
if 'file_naming' in self.kwargs:
683+
kwargs = dict(self.kwargs)
684+
if 'file_naming' in kwargs:
684685
dir, name = self.path, ''
685686
else:
686687
dir, name = io.filesystems.FileSystems.split(self.path)
687-
num_shards = self.kwargs.pop('num_shards', None)
688-
max_writers_per_bundle = self.kwargs.pop('max_writers_per_bundle', None)
688+
num_shards = kwargs.pop('num_shards', None)
689+
max_writers_per_bundle = kwargs.pop('max_writers_per_bundle', None)
689690
write_to_files_kwargs = {}
690691
if num_shards is not None:
691692
write_to_files_kwargs['shards'] = num_shards
692693
write_to_files_kwargs['max_writers_per_bundle'] = (
693-
0 if max_writers_per_bundle is None else max_writers_per_bundle)
694+
max_writers_per_bundle if max_writers_per_bundle is not None else 0)
694695
elif max_writers_per_bundle is not None:
695696
write_to_files_kwargs['max_writers_per_bundle'] = max_writers_per_bundle
696697
return pcoll | fileio.WriteToFiles(
697698
path=dir,
698-
file_naming=self.kwargs.pop(
699-
'file_naming', fileio.default_file_naming(name)),
699+
file_naming=kwargs.pop('file_naming', fileio.default_file_naming(name)),
700700
sink=lambda _: _WriteToPandasFileSink(
701-
self.writer, self.args, self.kwargs, self.incremental, self.binary),
701+
self.writer, self.args, kwargs, self.incremental, self.binary),
702702
**write_to_files_kwargs)
703703

704704

0 commit comments

Comments
 (0)