Increase CallTest sleep durations to keep test from being flaky due to timeout not being observed.

Decrease configured timeouts from 1 minute to 1 second or 10 seconds to speed up test execution.

Author: scwhittle

sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/CallTest.java

@@ -123,7 +123,10 @@ public void givenCallerThrowsQuotaException_emitsIntoFailurePCollection() {
 
   @Test
   public void givenCallerTimeout_emitsFailurePCollection() {
-    Duration timeout = Duration.standardMinutes(1L);
+    // This timeout applies both to processing and setup/teardown. Too low of values causes the
+    // timeout to be triggered
+    // on setup/teardown methods unexpectedly.
+    Duration timeout = Duration.standardSeconds(10L);
     Result<Response> result =
         pipeline
             .apply(Create.of(new Request("a")))
@@ -182,8 +185,7 @@ public void givenSetupThrowsQuotaException_throwsError() {
 
   @Test
   public void givenSetupTimeout_throwsError() {
-    Duration timeout = Duration.standardMinutes(1L);
-
+    Duration timeout = Duration.standardSeconds(1L);
     pipeline
         .apply(Create.of(new Request("")))
         .apply(
@@ -231,7 +233,7 @@ public void givenTeardownThrowsQuotaException_throwsError() {
 
   @Test
   public void givenTeardownTimeout_throwsError() {
-    Duration timeout = Duration.standardMinutes(1L);
+    Duration timeout = Duration.standardSeconds(1L);
     pipeline
         .apply(Create.of(new Request("")))
         .apply(
@@ -271,7 +273,7 @@ public void givenValidCaller_emitValidResponse() {
   private static class ValidCaller implements Caller<Request, Response> {
 
     @Override
-    public Response call(Request request) throws UserCodeExecutionException {
+    public Response call(Request request) {
       return new Response(request.id);
     }
   }
@@ -282,7 +284,7 @@ private static class UnSerializableCaller implements Caller<Request, Response> {
     private final UnSerializable nestedThing = new UnSerializable();
 
     @Override
-    public Response call(Request request) throws UserCodeExecutionException {
+    public Response call(Request request) {
       return new Response(request.id);
     }
   }
@@ -291,10 +293,10 @@ private static class UnSerializableCallerWithSetupTeardown extends UnSerializabl
       implements SetupTeardown {
 
     @Override
-    public void setup() throws UserCodeExecutionException {}
+    public void setup() {}
 
     @Override
-    public void teardown() throws UserCodeExecutionException {}
+    public void teardown() {}
   }
 
   private static class UnSerializable {}
@@ -358,11 +360,11 @@ private static class CallerExceedsTimeout implements Caller<Request, Response> {
     private final Duration timeout;
 
     CallerExceedsTimeout(Duration timeout) {
-      this.timeout = timeout.plus(Duration.standardSeconds(1L));
+      this.timeout = timeout.plus(Duration.standardSeconds(10L));
     }
 
     @Override
-    public Response call(Request request) throws UserCodeExecutionException {
+    public Response call(Request request) {
       sleep(timeout);
       return new Response(request.id);
     }
@@ -397,16 +399,16 @@ private static class SetupExceedsTimeout implements SetupTeardown {
     private final Duration timeout;
 
     private SetupExceedsTimeout(Duration timeout) {
-      this.timeout = timeout.plus(Duration.standardSeconds(1L));
+      this.timeout = timeout.plus(Duration.standardSeconds(10L));
     }
 
     @Override
-    public void setup() throws UserCodeExecutionException {
+    public void setup() {
       sleep(timeout);
     }
 
     @Override
-    public void teardown() throws UserCodeExecutionException {}
+    public void teardown() {}
   }
 
   private static class SetupThrowsUserCodeExecutionException implements SetupTeardown {
@@ -416,7 +418,7 @@ public void setup() throws UserCodeExecutionException {
     }
 
     @Override
-    public void teardown() throws UserCodeExecutionException {}
+    public void teardown() {}
   }
 
   private static class SetupThrowsUserCodeQuotaException implements SetupTeardown {
@@ -426,7 +428,7 @@ public void setup() throws UserCodeExecutionException {
     }
 
     @Override
-    public void teardown() throws UserCodeExecutionException {}
+    public void teardown() {}
   }
 
   private static class SetupThrowsUserCodeTimeoutException implements SetupTeardown {
@@ -436,28 +438,28 @@ public void setup() throws UserCodeExecutionException {
     }
 
     @Override
-    public void teardown() throws UserCodeExecutionException {}
+    public void teardown() {}
   }
 
   private static class TeardownExceedsTimeout implements SetupTeardown {
     private final Duration timeout;
 
     private TeardownExceedsTimeout(Duration timeout) {
-      this.timeout = timeout.plus(Duration.standardSeconds(1L));
+      this.timeout = timeout.plus(Duration.standardSeconds(10L));
     }
 
     @Override
-    public void setup() throws UserCodeExecutionException {}
+    public void setup() {}
 
     @Override
-    public void teardown() throws UserCodeExecutionException {
+    public void teardown() {
       sleep(timeout);
     }
   }
 
   private static class TeardownThrowsUserCodeExecutionException implements SetupTeardown {
     @Override
-    public void setup() throws UserCodeExecutionException {}
+    public void setup() {}
 
     @Override
     public void teardown() throws UserCodeExecutionException {
@@ -467,7 +469,7 @@ public void teardown() throws UserCodeExecutionException {
 
   private static class TeardownThrowsUserCodeQuotaException implements SetupTeardown {
     @Override
-    public void setup() throws UserCodeExecutionException {}
+    public void setup() {}
 
     @Override
     public void teardown() throws UserCodeExecutionException {
@@ -477,7 +479,7 @@ public void teardown() throws UserCodeExecutionException {
 
   private static class TeardownThrowsUserCodeTimeoutException implements SetupTeardown {
     @Override
-    public void setup() throws UserCodeExecutionException {}
+    public void setup() {}
 
     @Override
     public void teardown() throws UserCodeExecutionException {
@@ -519,14 +521,12 @@ private static class DeterministicRequestCoder extends CustomCoder<@NonNull Requ
     private static final Coder<String> ID_CODER = StringUtf8Coder.of();
 
     @Override
-    public void encode(Request value, @NotNull OutputStream outStream)
-        throws CoderException, IOException {
+    public void encode(Request value, @NotNull OutputStream outStream) throws IOException {
       ID_CODER.encode(checkStateNotNull(value).id, outStream);
     }
 
     @Override
-    public @NonNull Request decode(@NotNull InputStream inStream)
-        throws CoderException, IOException {
+    public @NonNull Request decode(@NotNull InputStream inStream) throws IOException {
       String id = ID_CODER.decode(inStream);
       return new Request(id);
     }
@@ -542,7 +542,7 @@ private static class DeterministicResponseCoder extends CustomCoder<Response> {
 
     @Override
     public void encode(@Nullable Response value, @NotNull OutputStream outStream)
-        throws CoderException, IOException {
+        throws IOException {
       if (value == null) {
         ID_CODER.encode(null, outStream);
         return;
@@ -551,7 +551,7 @@ public void encode(@Nullable Response value, @NotNull OutputStream outStream)
     }
 
     @Override
-    public Response decode(@NotNull InputStream inStream) throws CoderException, IOException {
+    public Response decode(@NotNull InputStream inStream) throws IOException {
       try {
         String id = ID_CODER.decode(inStream);
         return new Response(id);