Skip to content

Commit c54595b

Browse files
authored
Merge pull request #39111: Fix OpenSearch username/password env fallback in examples
2 parents 5b441f2 + 202d339 commit c54595b

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

examples/notebooks/beam-ml/rag_usecase/opensearch_connector.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ def __init__(self,
8888
"""
8989
self.host = host
9090
self.port = port
91-
self.username = username | os.getenv("OPENSEARCH_USERNAME")
92-
self.password = password | os.getenv("OPENSEARCH_PASSWORD")
91+
self.username = username or os.getenv("OPENSEARCH_USERNAME")
92+
self.password = password or os.getenv("OPENSEARCH_PASSWORD")
9393
self._batch_size = batch_size
9494

9595
if not self.username or not self.password:
@@ -247,8 +247,8 @@ def __init__(self,
247247
"""
248248
self.host = host
249249
self.port = port
250-
self.username = username | os.getenv("OPENSEARCH_USERNAME")
251-
self.password = password | os.getenv("OPENSEARCH_PASSWORD")
250+
self.username = username or os.getenv("OPENSEARCH_USERNAME")
251+
self.password = password or os.getenv("OPENSEARCH_PASSWORD")
252252
self.batch_size = batch_size
253253
self.embedded_columns = embedded_columns
254254

examples/notebooks/beam-ml/rag_usecase/opensearch_enrichment.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ def __init__(
7777
"""
7878
self.opensearch_host = opensearch_host
7979
self.opensearch_port = opensearch_port
80-
self.username = username | os.getenv("OPENSEARCH_USERNAME")
81-
self.password = password | os.getenv("OPENSEARCH_PASSWORD")
80+
self.username = username or os.getenv("OPENSEARCH_USERNAME")
81+
self.password = password or os.getenv("OPENSEARCH_PASSWORD")
8282
self.index_name = index_name
8383
self.vector_field = vector_field
8484
self.k = k

0 commit comments

Comments
 (0)