Skip to content

Commit d0b68de

Browse files
committed
sdks/python: address gemini comments
1 parent 8ac2c42 commit d0b68de

2 files changed

Lines changed: 4 additions & 12 deletions

File tree

CHANGES.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,8 @@
7575
* X feature added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)).
7676
* Python examples added for Milvus search enrichment handler on [Beam Website](https://beam.apache.org/documentation/transforms/python/elementwise/enrichment-milvus/)
7777
including jupyter notebook example (Python) ([#36176](https://github.com/apache/beam/issues/36176)).
78-
* Milvus sink I/O connector added (Python) ([#36702](
79-
https://github.com/apache/beam/issues/36702)). Now Beam has full support for
80-
Milvus integration including Milvus enrichment and sink operations.
78+
* Milvus sink I/O connector added (Python) ([#36702](https://github.com/apache/beam/issues/36702)).
79+
Now Beam has full support for Milvus integration including Milvus enrichment and sink operations.
8180

8281
## Breaking Changes
8382

sdks/python/apache_beam/ml/rag/ingestion/milvus_search_it_test.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -370,10 +370,7 @@ def test_write_on_existent_collection_with_default_schema(self):
370370
for chunk in test_chunks:
371371
self.assertIn(chunk.id, result_by_id)
372372
result_item = result_by_id[chunk.id]
373-
self.assertEqual(
374-
result_item["content"],
375-
chunk.content.text
376-
if hasattr(chunk.content, 'text') else chunk.content)
373+
self.assertEqual(result_item["content"], chunk.content.text)
377374
self.assertEqual(result_item["metadata"], chunk.metadata)
378375

379376
# Verify embedding is present and has correct length.
@@ -388,11 +385,7 @@ def test_write_with_custom_column_specifications(self):
388385

389386
custom_column_specs = [
390387
ColumnSpec("id", int, lambda chunk: int(chunk.id) if chunk.id else 0),
391-
ColumnSpec(
392-
"content",
393-
str, lambda chunk: (
394-
chunk.content.text
395-
if hasattr(chunk.content, 'text') else chunk.content)),
388+
ColumnSpec("content", str, lambda chunk: chunk.content.text),
396389
ColumnSpec("metadata", dict, lambda chunk: chunk.metadata or {}),
397390
ColumnSpec(
398391
"embedding",

0 commit comments

Comments
 (0)