Skip to content

Commit e1e06d2

Browse files
committed
Add setter and getter methods for iops and throughput
1 parent 0551fd8 commit e1e06d2

2 files changed

Lines changed: 31 additions & 26 deletions

File tree

runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -193,16 +193,19 @@ public String getAlgorithm() {
193193

194194
void setWorkerDiskType(String value);
195195

196-
@Description("IOPS provisioned for the root disk for VMs. If zero or " +
197-
"unspecified, the service will attempt to choose a reasonable default.")
198-
Long getDiskProvisionedIops();
199-
void setDiskProvisionedIops(Long diskProvisionedIops);
196+
@Description(
197+
"IOPS provisioned for the root disk for VMs. If zero or "
198+
+ "unspecified, the service will attempt to choose a reasonable default.")
199+
Long getDiskProvisionedIops();
200+
201+
void setDiskProvisionedIops(Long diskProvisionedIops);
200202

201-
@Description("Throughput provisioned in MiB/s for the root disk for VMs. If zero or " +
202-
"unspecified, the service will attempt to choose a reasonable default.")
203-
Long getDiskProvisionedThroughputMibps();
204-
void setDiskProvisionedThroughputMibps(Long diskProvisionedThroughputMibps);
203+
@Description(
204+
"Throughput provisioned in MiB/s for the root disk for VMs. If zero or "
205+
+ "unspecified, the service will attempt to choose a reasonable default.")
206+
Long getDiskProvisionedThroughputMibps();
205207

208+
void setDiskProvisionedThroughputMibps(Long diskProvisionedThroughputMibps);
206209

207210
/**
208211
* Specifies whether worker pools should be started with public IP addresses.

runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -619,29 +619,31 @@ public void testDiskSizeGbConfig() throws IOException {
619619
assertEquals(diskSizeGb, job.getEnvironment().getWorkerPools().get(0).getDiskSizeGb());
620620
}
621621

622-
@Test
623-
public void testDiskProvisioningTranslation() {
624-
DataflowPipelineOptions options = PipelineOptionsFactory.create().as(DataflowPipelineOptions.class);
625-
options.setDiskProvisionedIops(Long.valueOf(7000));
626-
options.setDiskProvisionedThroughputMibps(Long.valueOf(250));
627-
options.setProject("test-project"); // Required for translator
622+
@Test
623+
public void testDiskProvisioningTranslation() {
624+
DataflowPipelineOptions options =
625+
PipelineOptionsFactory.create().as(DataflowPipelineOptions.class);
626+
options.setDiskProvisionedIops(Long.valueOf(7000));
627+
options.setDiskProvisionedThroughputMibps(Long.valueOf(250));
628+
options.setProject("test-project"); // Required for translator
628629

629-
WorkerPool pool = translateWorkerPool(options);
630+
WorkerPool pool = translateWorkerPool(options);
630631

631-
assertEquals(Long.valueOf(7000), pool.getDiskProvisionedIops());
632-
assertEquals(Long.valueOf(250), pool.getDiskProvisionedThroughputMibps());
633-
}
632+
assertEquals(Long.valueOf(7000), pool.getDiskProvisionedIops());
633+
assertEquals(Long.valueOf(250), pool.getDiskProvisionedThroughputMibps());
634+
}
634635

635-
@Test
636-
public void testDiskProvisioningTranslationDefaults() {
637-
DataflowPipelineOptions options = PipelineOptionsFactory.create().as(DataflowPipelineOptions.class);
638-
options.setProject("test-project"); // Required for translator
636+
@Test
637+
public void testDiskProvisioningTranslationDefaults() {
638+
DataflowPipelineOptions options =
639+
PipelineOptionsFactory.create().as(DataflowPipelineOptions.class);
640+
options.setProject("test-project"); // Required for translator
639641

640-
WorkerPool pool = translateWorkerPool(options);
642+
WorkerPool pool = translateWorkerPool(options);
641643

642-
assertNull(pool.getDiskProvisionedIops());
643-
assertNull(pool.getDiskProvisionedThroughputMibps());
644-
}
644+
assertNull(pool.getDiskProvisionedIops());
645+
assertNull(pool.getDiskProvisionedThroughputMibps());
646+
}
645647

646648
/** A composite transform that returns an output that is unrelated to the input. */
647649
private static class UnrelatedOutputCreator

0 commit comments

Comments
 (0)