Skip to content

Commit e948ef6

Browse files
authored
Roll forward io expansion service to Java17 (#38974)
* Second try moving io expansion service to Java17 * fixing xlang issue * Fix cross-language CI by auto-discovering JDK homes and setting Java 17 as default * invert java 11 / 17 order installation * fix gemini * fix gemini * decouple BeamModulePlugin and setup-environment-action from GHA infra
1 parent 06aa37b commit e948ef6

17 files changed

Lines changed: 78 additions & 14 deletions

.github/actions/setup-environment-action/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ runs:
7171
7272
- name: Install Java
7373
if: ${{ inputs.java-version != '' }}
74-
uses: actions/setup-java@v3
74+
uses: actions/setup-java@v4
7575
with:
7676
distribution: 'temurin'
7777
java-version: ${{ inputs.java-version == 'default' && '11' || inputs.java-version }}

.github/workflows/beam_PerformanceTests_xlang_KafkaIO_Python.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ jobs:
7373
- name: Setup environment
7474
uses: ./.github/actions/setup-environment-action
7575
with:
76+
java-version: |
77+
17
78+
11
7679
python-version: default
7780
- name: Set k8s access
7881
uses: ./.github/actions/setup-k8s-access
@@ -179,6 +182,8 @@ jobs:
179182
uses: ./.github/actions/gradle-command-self-hosted-action
180183
with:
181184
gradle-command: :sdks:java:io:expansion-service:shadowJar
185+
arguments: |
186+
-Pjava17Home=$JAVA_HOME_17_X64
182187
# The env variable is created and populated in the test-arguments-action as "<github.job>_test_arguments_<argument_file_paths_index>"
183188
- name: run integrationTest
184189
uses: ./.github/actions/gradle-command-self-hosted-action

.github/workflows/beam_PostCommit_Python_Xlang_Gcp_Dataflow.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ jobs:
7474
- name: Setup environment
7575
uses: ./.github/actions/setup-environment-action
7676
with:
77+
java-version: |
78+
17
79+
11
7780
python-version: |
7881
3.10
7982
3.14
@@ -84,6 +87,7 @@ jobs:
8487
arguments: |
8588
-PpythonVersion=3.14 \
8689
-PuseWheelDistribution \
90+
-Pjava17Home=$JAVA_HOME_17_X64 \
8791
- name: Archive Python Test Results
8892
uses: actions/upload-artifact@v7
8993
if: failure()

.github/workflows/beam_PostCommit_Python_Xlang_Gcp_Direct.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ jobs:
7474
- name: Setup environment
7575
uses: ./.github/actions/setup-environment-action
7676
with:
77+
java-version: |
78+
17
79+
11
7780
python-version: |
7881
3.10
7982
3.14
@@ -85,6 +88,8 @@ jobs:
8588
uses: ./.github/actions/gradle-command-self-hosted-action
8689
with:
8790
gradle-command: :sdks:python:test-suites:direct:gcpCrossLanguagePostCommit
91+
arguments: |
92+
-Pjava17Home=$JAVA_HOME_17_X64
8893
- name: Archive Python Test Results
8994
uses: actions/upload-artifact@v7
9095
if: failure()

.github/workflows/beam_PostCommit_Python_Xlang_IO_Dataflow.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ jobs:
7373
- name: Setup environment
7474
uses: ./.github/actions/setup-environment-action
7575
with:
76+
java-version: |
77+
17
78+
11
7679
python-version: |
7780
3.10
7881
3.14
@@ -84,6 +87,7 @@ jobs:
8487
-PpythonVersion=3.14 \
8588
-PuseWheelDistribution \
8689
-PkafkaBootstrapServer=10.128.0.40:9094,10.128.0.28:9094,10.128.0.165:9094 \
90+
-Pjava17Home=$JAVA_HOME_17_X64 \
8791
- name: Archive Python Test Results
8892
uses: actions/upload-artifact@v7
8993
if: failure()

.github/workflows/beam_PostCommit_Python_Xlang_IO_Direct.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,19 @@ jobs:
7373
- name: Setup environment
7474
uses: ./.github/actions/setup-environment-action
7575
with:
76+
java-version: |
77+
17
78+
11
7679
python-version: |
7780
3.10
7881
3.14
7982
- name: run PostCommit Python Xlang IO Direct script
8083
uses: ./.github/actions/gradle-command-self-hosted-action
8184
with:
8285
gradle-command: :sdks:python:test-suites:direct:ioCrossLanguagePostCommit
83-
arguments: -PuseWheelDistribution
86+
arguments: |
87+
-PuseWheelDistribution \
88+
-Pjava17Home=$JAVA_HOME_17_X64
8489
- name: Archive Python Test Results
8590
uses: actions/upload-artifact@v7
8691
if: failure()

.github/workflows/beam_PostCommit_TransformService_Direct.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ jobs:
7474
- name: Setup environment
7575
uses: ./.github/actions/setup-environment-action
7676
with:
77-
java-version: 11
77+
java-version: |
78+
17
79+
11
7880
python-version: |
7981
3.10
8082
${{ matrix.python_version }}
@@ -83,7 +85,8 @@ jobs:
8385
with:
8486
gradle-command: :sdks:python:test-suites:direct:xlang:transformServicePythonUsingJava
8587
arguments: |
86-
-PtestJavaVersion=11 \
88+
-PtestJavaVersion=17 \
89+
-Pjava17Home=$JAVA_HOME_17_X64 \
8790
-Pjava11Home=$JAVA_HOME_11_X64 \
8891
-PpythonVersion=${{ matrix.python_version }} \
8992
- name: Archive Python Test Results

.github/workflows/beam_PostCommit_XVR_Direct.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ jobs:
7474
- name: Setup environment
7575
uses: ./.github/actions/setup-environment-action
7676
with:
77+
java-version: |
78+
17
79+
11
7780
python-version: ${{ matrix.python_version }}
7881
- name: run PostCommit XVR Direct script
7982
env:
@@ -83,6 +86,7 @@ jobs:
8386
gradle-command: :sdks:python:test-suites:direct:xlang:validatesCrossLanguageRunner
8487
arguments: |
8588
-PpythonVersion=${{ matrix.python_version }} \
89+
-Pjava17Home=$JAVA_HOME_17_X64 \
8690
-PskipNonPythonTask=${{ (matrix.python_version == '3.10' && true) || false }} \
8791
- name: Archive JUnit Test Results
8892
uses: actions/upload-artifact@v7

.github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,17 @@ jobs:
7474
uses: ./.github/actions/setup-environment-action
7575
with:
7676
python-version: default
77-
java-version: '11'
77+
java-version: |
78+
17
79+
11
7880
- name: Set up Cloud SDK
7981
uses: google-github-actions/setup-gcloud@aa5489c8933f4cc7a4f7d45035b3b1440c9c10db
8082
- name: run PostCommit Yaml Xlang Direct script
8183
uses: ./.github/actions/gradle-command-self-hosted-action
8284
with:
8385
gradle-command: :sdks:python:postCommitYamlIntegrationTests -PyamlTestSet=${{ matrix.test_set }} -PbeamPythonExtra=p310_ml_test,yaml
86+
arguments: |
87+
-Pjava17Home=$JAVA_HOME_17_X64
8488
- name: Archive Python Test Results
8589
uses: actions/upload-artifact@v7
8690
if: failure()

.github/workflows/beam_PreCommit_Xlang_Generated_Transforms.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,9 @@ jobs:
102102
- name: Setup environment
103103
uses: ./.github/actions/setup-environment-action
104104
with:
105-
java-version: default
105+
java-version: |
106+
17
107+
11
106108
python-version: ${{ matrix.python_version }}
107109
- name: Set PY_VER_CLEAN
108110
id: set_py_ver_clean
@@ -114,3 +116,5 @@ jobs:
114116
uses: ./.github/actions/gradle-command-self-hosted-action
115117
with:
116118
gradle-command: :sdks:python:test-suites:direct:crossLanguageWrapperValidationPreCommit --info
119+
arguments: |
120+
-Pjava17Home=$JAVA_HOME_17_X64

0 commit comments

Comments
 (0)