Skip to content

Commit f13ccf7

Browse files
authored
Merge pull request #39077 from Abacn/fix-flink-xvr
Fix Flink XVR Tests for Flink 2
2 parents 5afb93c + 16acfa8 commit f13ccf7

7 files changed

Lines changed: 25 additions & 10 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"comment": "Modify this file in a trivial way to cause this test suite to run",
3-
"modification": 2,
3+
"modification": 3,
44
"https://github.com/apache/beam/pull/32440": "testing datastream optimizations",
55
"pr": "37640"
66
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
2-
"modification": 2,
2+
"modification": 3,
33
"trigger-2026-04-04": "portable_runner expand_sdf opt-in"
44
}

.github/trigger_files/beam_PostCommit_XVR_Samza.json

Lines changed: 0 additions & 1 deletion
This file was deleted.

CHANGES.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@
7575
* (Java) Enabled state tag encoding v2 by default for new Dataflow Streaming Engine jobs. It can be disabled by passing `--experiments=disable_streaming_engine_state_tag_encoding_v2` or `--updateCompatibilityVersion=2.74.0` pipeline option. Note that the tag encoding version cannot change during a job update. Jobs using tag encoding v2 (enabled by default for new jobs on 2.75.0+) cannot be downgraded to Beam versions prior to 2.73.0, as only versions 2.73.0 and later support tag encoding v2. ([#38705](https://github.com/apache/beam/issues/38705)).
7676
* (Python) Added instrumentation to support off-the-shelf profiling agents when launching Python SDK Harness ([#38853](https://github.com/apache/beam/issues/38853)).
7777
* (Java) Added support to the FnApi Data stream protocol allowing runners to isolate bundles slowly processing input from other bundles. ([#39001](https://github.com/apache/beam/issues/39001)).
78-
* (Java) Flink 2.1 support added ([#38947](https://github.com/apache/beam/issues/38947)).
79-
* (Java) Flink 2.2 support added ([#38978](https://github.com/apache/beam/issues/38978)).
78+
* (Java) Flink 2.1 and 2.2 support is added ([#38947](https://github.com/apache/beam/issues/38947)) ([#38978](https://github.com/apache/beam/issues/38978)); Flink 1.17 and 1.18 support is dropped.
79+
* (Python) MqttIO is now supported in Python via cross-language ([#21060](https://github.com/apache/beam/issues/21060)).
8080

8181
## Breaking Changes
8282

runners/flink/job-server/flink_job_server.gradle

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,10 +248,26 @@ def setupTask = project.tasks.register("flinkJobServerSetup", Exec) {
248248
def flinkJobServerJar = shadowJar.archivePath
249249
def flinkDir = project.project(":runners:flink").projectDir
250250
def additionalArgs = ""
251-
if (project.hasProperty('flinkConfDir'))
251+
252+
if (project.hasProperty('flinkConfDir')) {
252253
additionalArgs += " --flink-conf-dir=${project.property('flinkConfDir')}"
253-
else
254+
}
255+
else if (isFlink2) {
256+
def flinkConfDir = "$flinkDir/2.0/src/test/resources"
257+
additionalArgs += "--flink-conf-dir=${project.buildDir}/flink-conf"
258+
259+
doFirst {
260+
copy {
261+
from "$flinkDir/2.0/src/test/resources/flink-test-config.yaml"
262+
into "${project.buildDir}/flink-conf"
263+
264+
// Rename the file during the copy process
265+
rename 'flink-test-config.yaml', 'config.yaml'
266+
}
267+
}
268+
} else {
254269
additionalArgs += "--flink-conf-dir=$flinkDir/src/test/resources"
270+
}
255271

256272
executable 'sh'
257273
args '-c', "$pythonDir/scripts/run_job_server.sh stop --group_id ${project.name} && $pythonDir/scripts/run_job_server.sh start --group_id ${project.name} --job_port ${jobPort} --artifact_port ${artifactPort} --job_server_jar ${flinkJobServerJar} --additional_args \"${additionalArgs}\""

sdks/go/test/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ task flinkValidatesRunner {
9292
doFirst {
9393
// Copy Flink conf file
9494
copy {
95-
from "${project.rootDir}/runners/flink/${flinkVersion}/src/test/resources/flink-test-config.yaml"
95+
from "${project.rootDir}/runners/flink/2.0/src/test/resources/flink-test-config.yaml"
9696
into "${project.buildDir}/flink-conf"
9797

9898
// Rename the file during the copy process

website/www/site/content/en/documentation/runners/flink.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,12 +358,12 @@ To find out which version of Flink is compatible with Beam please see the table
358358
<tr>
359359
<td>1.18.x</td>
360360
<td>beam-runners-flink-1.18</td>
361-
<td>&ge; 2.57.0</td>
361+
<td>2.57.0 - 2.74.0</td>
362362
</tr>
363363
<tr>
364364
<td>1.17.x</td>
365365
<td>beam-runners-flink-1.17</td>
366-
<td>&ge; 2.56.0</td>
366+
<td>2.56.0 - 2.74.0</td>
367367
</tr>
368368
<tr>
369369
<td>1.16.x</td>

0 commit comments

Comments
 (0)