Skip to content

Commit f8c6594

Browse files
committed
Add some comments to tests.
1 parent 06315f5 commit f8c6594

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

sdks/go/pkg/beam/runners/prism/internal/engine/strategy_test.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -409,10 +409,10 @@ func TestTriggers_isReady(t *testing.T) {
409409
},
410410
},
411411
inputs: []io{
412-
{triggerInput{emNow: 0}, false},
412+
{triggerInput{emNow: 0}, false}, // the trigger is set to fire at 3s after 0
413413
{triggerInput{emNow: 1000}, false},
414414
{triggerInput{emNow: 2000}, false},
415-
{triggerInput{emNow: 3000}, true},
415+
{triggerInput{emNow: 3000}, true}, // fire
416416
{triggerInput{emNow: 4000}, false},
417417
{triggerInput{emNow: 5000}, false},
418418
{triggerInput{emNow: 6000}, false},
@@ -426,10 +426,10 @@ func TestTriggers_isReady(t *testing.T) {
426426
},
427427
},
428428
inputs: []io{
429-
{triggerInput{emNow: 0}, false},
429+
{triggerInput{emNow: 0}, false}, // the trigger is set to fire at 3s after 0
430430
{triggerInput{emNow: 1000}, false},
431431
{triggerInput{emNow: 2000}, false},
432-
{triggerInput{emNow: 3001}, true}, // a little after the expected firing time
432+
{triggerInput{emNow: 3001}, true}, // fire a little after the preset time
433433
{triggerInput{emNow: 4000}, false},
434434
},
435435
}, {
@@ -440,10 +440,10 @@ func TestTriggers_isReady(t *testing.T) {
440440
},
441441
},
442442
inputs: []io{
443-
{triggerInput{emNow: 1500}, false},
443+
{triggerInput{emNow: 1500}, false}, // align 1.5s to 5s
444444
{triggerInput{emNow: 2000}, false},
445445
{triggerInput{emNow: 4999}, false},
446-
{triggerInput{emNow: 5000}, true}, // 1.5 is aligned to 5
446+
{triggerInput{emNow: 5000}, true}, // fire at 5
447447
{triggerInput{emNow: 5001}, false},
448448
},
449449
}, {
@@ -454,10 +454,10 @@ func TestTriggers_isReady(t *testing.T) {
454454
},
455455
},
456456
inputs: []io{
457-
{triggerInput{emNow: 1500}, false},
457+
{triggerInput{emNow: 1500}, false}, // align 1.5s to 5s plus an 0.2 offset
458458
{triggerInput{emNow: 2000}, false},
459459
{triggerInput{emNow: 5119}, false},
460-
{triggerInput{emNow: 5200}, true}, // 1.5 is aligned to 5.2
460+
{triggerInput{emNow: 5200}, true}, // fire at 5.2s
461461
{triggerInput{emNow: 5201}, false},
462462
},
463463
}, {
@@ -469,13 +469,13 @@ func TestTriggers_isReady(t *testing.T) {
469469
},
470470
},
471471
inputs: []io{
472-
{triggerInput{emNow: 1500}, false},
472+
{triggerInput{emNow: 1500}, false}, // align 1.5s to 5s plus an 0.2 offset and a 1s delay
473473
{triggerInput{emNow: 2000}, false},
474474
{triggerInput{emNow: 5119}, false},
475475
{triggerInput{emNow: 5200}, false},
476476
{triggerInput{emNow: 5201}, false},
477477
{triggerInput{emNow: 6119}, false},
478-
{triggerInput{emNow: 6200}, true}, // 1.5 is aligned to 6.2
478+
{triggerInput{emNow: 6200}, true}, // fire
479479
{triggerInput{emNow: 6201}, false},
480480
},
481481
}, {

0 commit comments

Comments
 (0)