Skip to content

Create new SubProject to not depend on Dataflow in Kafka - #35452

Closed
fozzie15 wants to merge 1 commit into
apache:masterfrom
fozzie15:kafka_on_gmk_subproject
Closed

Create new SubProject to not depend on Dataflow in Kafka#35452
fozzie15 wants to merge 1 commit into
apache:masterfrom
fozzie15:kafka_on_gmk_subproject

Conversation

@fozzie15

Copy link
Copy Markdown
Contributor

These changes will add a new sub-project for kafka tests which depend on Dataflow. This will allow us to test changes on Dataflow without creating a circular dependency between Dataflow and Kafka. This test is required for the Managed Schema Transform Providers which have functionality when executed on Dataflow.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

name: PreCommit Java Kafka IO Dataflow

on:
push:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove push trigger. It's not quite useful in practice

pull_request_target:
branches: ['master', 'release-*']
paths:
- "sdks/java/io/kafka/**"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set to sdks/java/io/kafka/gmk-tests for now so it won't report failures on unrelated PR

@derrickaw

Copy link
Copy Markdown
Collaborator

waiting on author

@ahmedabu98

Copy link
Copy Markdown
Contributor

hey @fozzie15, is this PR still relevant?

@stankiewicz

Copy link
Copy Markdown
Contributor

is this PR still relevant?

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Nov 24, 2025
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants