Skip to content

Fix PostCommit Python ValidatesRunner Dataflow job - #36149

Merged
Abacn merged 1 commit into
masterfrom
fix-dill
Sep 17, 2025
Merged

Fix PostCommit Python ValidatesRunner Dataflow job#36149
Abacn merged 1 commit into
masterfrom
fix-dill

Conversation

@Amar3tto

Copy link
Copy Markdown
Collaborator

Fixes #36144
Successful run: https://github.com/apache/beam/actions/runs/17726486150


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue with the PostCommit Python ValidatesRunner Dataflow job by modifying a specific test case. The change ensures that the test_group_by_key_importable_special_types test, which relies on the dill serialization library, correctly imports and uses dill, preventing failures in environments where dill might not be readily available or properly recognized by the test runner.

Highlights

  • Test Fix: Addressed a failure in the PostCommit Python ValidatesRunner Dataflow job related to a specific test case.
  • Dill Dependency Handling: Ensured the test_group_by_key_importable_special_types test correctly handles its dependency on the dill library.
  • Pytest Markers and Imports: Introduced @pytest.mark.uses_dill and pytest.importorskip("dill") to manage the dill dependency within the test, allowing it to be skipped if dill is not available.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @tvalentyn for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn

Abacn commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

cc: @claudevdm to confirm this is intended

Comment thread sdks/python/apache_beam/transforms/ptransform_test.py Outdated
@Abacn
Abacn merged commit 9a5a357 into master Sep 17, 2025
106 of 108 checks passed
@Abacn
Abacn deleted the fix-dill branch September 17, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Python ValidatesRunner Dataflow job is flaky

3 participants