Skip to content

[Dataflow Streaming] Move functionality creating windmill tags to a common class. - #36283

Merged
scwhittle merged 4 commits into
apache:masterfrom
arunpandianp:windmillstatetagutil
Oct 10, 2025
Merged

[Dataflow Streaming] Move functionality creating windmill tags to a common class.#36283
scwhittle merged 4 commits into
apache:masterfrom
arunpandianp:windmillstatetagutil

Conversation

@arunpandianp

Copy link
Copy Markdown
Contributor

This is a prep to introduce new windmill tag encodings. No functionality change, just moving methods around.

…ommon class.

This is a prep to introduce new windmill tag encodings. No functionality
change.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @arunpandianp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the Dataflow Streaming worker's internal state management. Its primary purpose is to consolidate the creation of Windmill state and timer tags into a single, dedicated utility class, WindmillStateTagUtil. This move is a preparatory step, laying the groundwork for the future introduction of new Windmill tag encodings without altering the current behavior or functionality of the system.

Highlights

  • Centralized Tag Creation: All Windmill state and timer tag creation logic has been consolidated into a new dedicated utility class, WindmillStateTagUtil.
  • Refactored WindmillStateUtil: The existing WindmillStateUtil class was renamed to WindmillStateTagUtil. This new class now houses the encodeKey method (previously static in WindmillStateUtil) and the timerHoldTag method (moved from WindmillTimerInternals).
  • Dependency Injection for Tag Utilities: Various Windmill state and timer-related classes, including StreamingModeExecutionContext, WindmillTimerInternals, CachingStateTable, and several Windmill*State implementations, have been updated to receive an instance of WindmillStateTagUtil via their constructors. This ensures consistent usage of the centralized tag creation logic.
  • No Functional Change: This pull request is purely a refactoring effort, introducing no changes to existing functionality. It serves as a preparatory step for future enhancements related to new Windmill tag encodings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@arunpandianp

Copy link
Copy Markdown
Contributor Author

R: @scwhittle

cc: @reuvenlax

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@scwhittle
scwhittle merged commit 65ee225 into apache:master Oct 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants