Skip to content

Implement histogram user metric for python SDK - #36335

Merged
hjtran merged 12 commits into
apache:masterfrom
hjtran:histogram
Oct 3, 2025
Merged

Implement histogram user metric for python SDK#36335
hjtran merged 12 commits into
apache:masterfrom
hjtran:histogram

Conversation

@hjtran

@hjtran hjtran commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Resolves #36267

Implement the Histogram metric for the python SDK.

I'm going to do the actual moving of all histogram related stuff from internal/metric.py to the public metric.py in a separate PR to make this PR easier to review.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@hjtran hjtran changed the title Histogram Implement histogram user metric for python SDK Oct 1, 2025
@hjtran
hjtran marked this pull request as ready for review October 1, 2025 10:41
@hjtran

hjtran commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

failure test_enrichment_with_bigtable (apache_beam.examples.snippets.transforms.elementwise.enrichment_test.EnrichmentTest) looks unrelated

@hjtran

hjtran commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

assign set of reviewers

@github-actions

github-actions Bot commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@hjtran

hjtran commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

Hey @claudevdm , do you have time to review this? No worries if not, I can request another reviewer if so

@claudevdm

Copy link
Copy Markdown
Collaborator

R: @claudevdm

Sorry missed this, will take a look today or tomorrow.

@github-actions

github-actions Bot commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Comment thread sdks/python/apache_beam/utils/histogram.py Outdated
@hjtran

hjtran commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the review @claudevdm !

@hjtran
hjtran merged commit 800e2d7 into apache:master Oct 3, 2025
101 of 118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Implement histogram metrics for the python SDK

2 participants