Skip to content

Add Java25 container - #36349

Merged
Abacn merged 2 commits into
apache:masterfrom
Abacn:java25container
Oct 2, 2025
Merged

Add Java25 container#36349
Abacn merged 2 commits into
apache:masterfrom
Abacn:java25container

Conversation

@Abacn

@Abacn Abacn commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

#35627

need a Beam master container release after this change

Tested with Dataflow runner v2 job (job id: 2025-10-01_11_00_05-9085012090506374637)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates support for Java 25 into the project's container build system. It establishes the necessary build configurations, security settings, and JVM options for a Java 25 container, and updates the internal Java version management to recognize and default to Java 25 for newer or unspecified Java environments. This enhancement ensures compatibility and readiness for future Java releases.

Highlights

  • Java 25 Container Support: Introduced a new Java 25 container, including its build configuration, security properties, and JVM options.
  • Build System Updates: Modified build.gradle files to incorporate the new Java 25 container into the build and push processes, including a placeholder for a future distroless Java 25 container.
  • Java Version Handling: Updated the JavaVersion enum in Environments.java to include Java 25 and adjusted the default fallback logic to prefer Java 25 for unspecified or newer versions.
  • Test Coverage: Added and updated unit tests to ensure correct resolution and handling of Java 25 and other non-LTS Java versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

github-actions Bot commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @ahmedabu98 for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn

Abacn commented Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

R: @damccorm @Amar3tto

@github-actions

github-actions Bot commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the security.properties question

*/

project.ext {
imageJavaVersion = '25'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open a jira like https://issues.apache.org/jira/browse/INFRA-27219?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel to get the java 25 dockerhub repo added?

Probably worth just asking for distroless as well even if we don't populate it for a while.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding that, opened INFRA-27303

"enabled": true,
"options": {
"properties": {
"java.security.properties": "/opt/apache/beam/options/java21-security.properties"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this point to java25-security.properties?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn
Abacn merged commit e61b4f3 into apache:master Oct 2, 2025
27 checks passed
@Abacn
Abacn deleted the java25container branch October 2, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants