Skip to content

Exit gradle process after build complete - #36361

Merged
tvalentyn merged 1 commit into
apache:masterfrom
tarun-google:fix_snapshots_build
Oct 2, 2025
Merged

Exit gradle process after build complete#36361
tvalentyn merged 1 commit into
apache:masterfrom
tarun-google:fix_snapshots_build

Conversation

@tarun-google

Copy link
Copy Markdown
Contributor

I have an guess, this will fix the Snapshots Build issue. I did some analysis to arrive at this

  1. We are successfully exporting the python images for every build
  2. We do this process for 4 python versions and not every time the same workflow times out. So, its just flakiness
  3. When the workflow completes, it actually completes in less than 2 hours. So, its not a time out
  4. I see many other build file has the --no-demon command. So, thought this addition might help close the process

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a modification to the Gradle command execution within a GitHub Action workflow. By adding the --no-daemon flag, the intention is to prevent Gradle daemon processes from persisting after a build, which is hypothesized to be the root cause of flakiness and timeouts in certain build pipelines, particularly those involving Python image exports. This change promotes cleaner process termination and aims to improve the reliability of automated builds.

Highlights

  • Addressing Build Flakiness: This pull request aims to resolve intermittent timeout issues observed in Python snapshot builds, which are suspected to be caused by lingering Gradle processes.
  • Gradle Daemon Management: The change explicitly adds the --no-daemon flag to the gradlew command within the gradle-command-self-hosted-action, ensuring that the Gradle process terminates immediately after the build completes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tarun-google

Copy link
Copy Markdown
Contributor Author

R: @tvalentyn

@github-actions

github-actions Bot commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @kennknowles added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn

Copy link
Copy Markdown
Contributor

Thanks! cc: @damccorm @Amar3tto FYI.

@tvalentyn
tvalentyn merged commit 3903623 into apache:master Oct 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants