Skip to content

feat(subprocess_server): add fallback to Google Maven mirror - #36365

Merged
liferoad merged 5 commits into
apache:masterfrom
liferoad:use-google-mirror-fallback
Oct 3, 2025
Merged

feat(subprocess_server): add fallback to Google Maven mirror #36365
liferoad merged 5 commits into
apache:masterfrom
liferoad:use-google-mirror-fallback

Conversation

@liferoad

@liferoad liferoad commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Implement fallback mechanism to use Google Maven mirror when downloads from Maven Central fail (e.g. 403 Forbidden). This improves reliability of jar downloads by providing an alternative source.

Addresses #36338


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

…en Central fails

Implement fallback mechanism to use Google Maven mirror when downloads from Maven Central fail (e.g. 403 Forbidden). This improves reliability of jar downloads by providing an alternative source.
@liferoad
liferoad requested review from Abacn and damccorm October 2, 2025 23:43
@github-actions github-actions Bot added the python label Oct 2, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @liferoad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical reliability enhancement for the subprocess_server by adding a fallback mechanism for Java JAR downloads. When attempts to fetch JARs from Maven Central encounter errors, such as a 403 Forbidden response, the system will now automatically try to download the required JARs from the Google Maven mirror. This change significantly improves the robustness of dependency resolution, ensuring that the system can continue to function even if the primary Maven Central repository experiences issues.

Highlights

  • Maven Download Fallback: Implemented a fallback mechanism to use the Google Maven mirror for JAR downloads when requests to Maven Central fail, specifically addressing 403 Forbidden errors.
  • Enhanced Reliability: Improves the reliability of JAR dependency resolution by providing an alternative download source, ensuring smoother operation even with intermittent Maven Central issues.
  • New Test Case: Added a new unit test to subprocess_server_test.py that verifies the Google Maven mirror fallback functionality by simulating a Maven Central failure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions

github-actions Bot commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Comment thread sdks/python/apache_beam/utils/subprocess_server.py Outdated
Comment thread sdks/python/apache_beam/utils/subprocess_server.py Outdated
… method

Move the jar download and caching logic from local_jar method to a new _download_jar_to_cache method to improve code reuse and maintainability

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@liferoad

liferoad commented Oct 3, 2025

Copy link
Copy Markdown
Contributor Author

failed workflows are not related to this PR.

@liferoad
liferoad merged commit 5af82f5 into apache:master Oct 3, 2025
106 of 125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants