Skip to content

feat(pipeline_options): add support for custom maven repository url - #36390

Merged
liferoad merged 7 commits into
apache:masterfrom
liferoad:add-custom-maven-url
Oct 10, 2025
Merged

feat(pipeline_options): add support for custom maven repository url#36390
liferoad merged 7 commits into
apache:masterfrom
liferoad:add-custom-maven-url

Conversation

@liferoad

@liferoad liferoad commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

Add --maven_repository_url flag to SetupOptions to allow specifying custom Maven repository Modify JavaJarServer, JavaJarExpansionService and BeamJarExpansionService to use custom repository Update _resolve_expansion_service to pass maven_repository_url from pipeline options Add unit tests for maven_repository_url functionality

Fixes #36338


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Add --maven_repository_url flag to SetupOptions to allow specifying custom Maven repository
Modify JavaJarServer, JavaJarExpansionService and BeamJarExpansionService to use custom repository
Update _resolve_expansion_service to pass maven_repository_url from pipeline options
Add unit tests for maven_repository_url functionality
@liferoad
liferoad requested review from Abacn and chamikaramj October 4, 2025 02:11
@github-actions github-actions Bot added the python label Oct 4, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @liferoad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Apache Beam Python SDK by providing users with the flexibility to specify a custom Maven repository URL. This is particularly useful for environments requiring dependencies from private or alternative repositories, moving beyond the default Maven Central. The changes involve adding a new pipeline option and ensuring this option is correctly propagated and utilized by the internal services responsible for managing and expanding Java JARs.

Highlights

  • New Pipeline Option: Introduced a new --maven_repository_url flag within SetupOptions to allow users to specify a custom Maven repository URL for downloading JAR files, defaulting to Maven Central if not provided.
  • Maven Repository Integration: Modified JavaJarServer, JavaJarExpansionService, and BeamJarExpansionService to accept and utilize the custom Maven repository URL when resolving and downloading JAR dependencies.
  • Pipeline Options Propagation: Updated the _resolve_expansion_service function to extract the maven_repository_url from pipeline options and pass it down to the expansion services, ensuring the custom URL is used consistently.
  • Unit Tests: Added comprehensive unit tests to verify the correct functionality and propagation of the maven_repository_url across the various components involved in JAR resolution and expansion.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Comment thread sdks/python/apache_beam/transforms/managed.py
@codecov

codecov Bot commented Oct 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.75472% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.18%. Comparing base (659cc4d) to head (c4a1761).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...pache_beam/transforms/test_maven_repository_url.py 23.25% 66 Missing ⚠️
sdks/python/apache_beam/transforms/managed.py 0.00% 14 Missing ⚠️
sdks/python/apache_beam/utils/subprocess_server.py 0.00% 3 Missing ⚠️
sdks/python/apache_beam/transforms/external.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #36390      +/-   ##
============================================
- Coverage     40.19%   40.18%   -0.02%     
  Complexity     3386     3386              
============================================
  Files          1220     1221       +1     
  Lines        186217   186413     +196     
  Branches       3523     3523              
============================================
+ Hits          74855    74913      +58     
- Misses       108001   108139     +138     
  Partials       3361     3361              
Flag Coverage Δ
python 40.51% <20.75%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just had formatting comments. And pleases fix Python Lint before merging

Comment thread sdks/python/apache_beam/transforms/external.py
Comment thread sdks/python/apache_beam/transforms/maven_repository_url_test.py
Comment thread sdks/python/apache_beam/utils/subprocess_server.py Outdated
@liferoad liferoad closed this Oct 9, 2025
@liferoad liferoad reopened this Oct 9, 2025
@liferoad liferoad closed this Oct 9, 2025
@liferoad liferoad reopened this Oct 9, 2025
@liferoad

Copy link
Copy Markdown
Contributor Author

Failed workflows are not related to this PR.

@liferoad
liferoad merged commit b2e1238 into apache:master Oct 10, 2025
152 of 164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Support more ways than Maven Central to download jars for Python x-lang use cases

2 participants