feat(pipeline_options): add support for custom maven repository url - #36390
Conversation
Add --maven_repository_url flag to SetupOptions to allow specifying custom Maven repository Modify JavaJarServer, JavaJarExpansionService and BeamJarExpansionService to use custom repository Update _resolve_expansion_service to pass maven_repository_url from pipeline options Add unit tests for maven_repository_url functionality
Summary of ChangesHello @liferoad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Apache Beam Python SDK by providing users with the flexibility to specify a custom Maven repository URL. This is particularly useful for environments requiring dependencies from private or alternative repositories, moving beyond the default Maven Central. The changes involve adding a new pipeline option and ensuring this option is correctly propagated and utilized by the internal services responsible for managing and expanding Java JARs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #36390 +/- ##
============================================
- Coverage 40.19% 40.18% -0.02%
Complexity 3386 3386
============================================
Files 1220 1221 +1
Lines 186217 186413 +196
Branches 3523 3523
============================================
+ Hits 74855 74913 +58
- Misses 108001 108139 +138
Partials 3361 3361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Abacn
left a comment
There was a problem hiding this comment.
Thanks, just had formatting comments. And pleases fix Python Lint before merging
|
Failed workflows are not related to this PR. |
Add --maven_repository_url flag to SetupOptions to allow specifying custom Maven repository Modify JavaJarServer, JavaJarExpansionService and BeamJarExpansionService to use custom repository Update _resolve_expansion_service to pass maven_repository_url from pipeline options Add unit tests for maven_repository_url functionality
Fixes #36338
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.