Skip to content

enrichment_test.EnrichmentTest flaky fix - #36407

Merged
liferoad merged 2 commits into
apache:masterfrom
stankiewicz:fix_flaky_vertex_enrichment
Oct 6, 2025
Merged

enrichment_test.EnrichmentTest flaky fix#36407
liferoad merged 2 commits into
apache:masterfrom
stankiewicz:fix_flaky_vertex_enrichment

Conversation

@stankiewicz

Copy link
Copy Markdown
Contributor

fixes:

<apache_beam.examples.snippets.transforms.elementwise.enrichment_test.EnrichmentTest testMethod=test_enrichment_with_vertex_ai>
mock_stdout = <_io.StringIO object at 0x7e42db61abc0>

    def test_enrichment_with_vertex_ai(self, mock_stdout):
      enrichment_with_vertex_ai()
      output = sorted(mock_stdout.getvalue().splitlines())
      expected = sorted(validate_enrichment_with_vertex_ai())
    
      for i in range(len(expected)):
>       self.assertEqual(set(output[i].split(',')), set(expected[i].split(',')))
E       AssertionError: Items in the first set but not the second:
E       " state='0')"
E       " country='0'"
E       Items in the second set but not the first:
E       " state='0'"
E       " country='0')"

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @stankiewicz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a flakiness problem in the test_enrichment_with_vertex_ai test. The fix involves refining the string comparison within the test's assertion to be more resilient to minor, non-semantic variations in the string output, thereby preventing intermittent test failures.

Highlights

  • Flaky Test Fix: Addresses a known flakiness issue in enrichment_test.EnrichmentTest.test_enrichment_with_vertex_ai that caused AssertionError due to inconsistent string formatting in the test output.
  • String Comparison Adjustment: Modifies the assertion logic in the test to apply string slicing ([4:-1]) to both the actual output and expected values before splitting them into sets for comparison. This ensures robust comparison despite minor formatting variations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@liferoad liferoad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liferoad
liferoad merged commit 7542aea into apache:master Oct 6, 2025
97 of 110 checks passed
@stankiewicz
stankiewicz deleted the fix_flaky_vertex_enrichment branch April 29, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants