Add logger helper functions from detectron2 (licensed as Apache 2.0) - #36432
Merged
Conversation
tvalentyn
marked this pull request as ready for review
October 10, 2025 17:51
Contributor
Author
|
R: @claudevdm |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
3 tasks
claudevdm
reviewed
Oct 10, 2025
| return "unknown", ("unknown", 0, "unknown") | ||
|
|
||
|
|
||
| _LOG_COUNTER = Counter() |
Collaborator
There was a problem hiding this comment.
Should this be protected by a lock?
Collaborator
There was a problem hiding this comment.
Same with access to _LOG_TIMER
Contributor
Author
There was a problem hiding this comment.
it's not necessary for the kind of modifications we have here (they won't cause a crash like one where you modify a dictionary while iterating it in another thread), and overheads of synchronization would likely outweigh the benefits. Indeed, there can be a race where log_every_n_seconds might emit a log twice but that should be fine.
claudevdm
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have several places in Python SDK where a certain log entry is emitted multiple times, when a single warning would be sufficient. This is causing excessive noise, particularly visible during job submission, when INFO logs are enabled.
We also have codepaths where we may want to log a particular message, but not more often than once per x minutes. Every time that happens, we add the same logic counting time, for example:
beam/sdks/python/apache_beam/runners/worker/data_plane.py
Line 167 in bea0444
abesil/abseil-py has handy helper functions that can reduce the logging footprint, and these inspirations were adapted in some other opensource projects. The adaptation in detectron2 is sufficiently decoupled from absl and should be easy to integrate with our codebase.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.