Skip to content

Add flag for disabling dill check in coders. - #36453

Merged
damccorm merged 6 commits into
apache:masterfrom
claudevdm:dill-tests-2
Oct 13, 2025
Merged

Add flag for disabling dill check in coders.#36453
damccorm merged 6 commits into
apache:masterfrom
claudevdm:dill-tests-2

Conversation

@claudevdm

@claudevdm claudevdm commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

This adds a flag for force using cloudpickle as deterministic coder if update compat flag is <2.68 due to unrelated issues.

This is helpful for testing (previous update compat tests dont have to run in dill workflow due to compat flag).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm

Copy link
Copy Markdown
Collaborator Author

R: @damccorm

@claudevdm
claudevdm marked this pull request as ready for review October 9, 2025 18:55
@github-actions

github-actions Bot commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Comment thread .github/workflows/beam_PreCommit_Python_Dill.yml Outdated
Comment thread sdks/python/apache_beam/options/pipeline_options.py
Comment thread sdks/python/apache_beam/coders/coders.py Outdated

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, tests are failing due to this change, please fix

label='CheckSinglePartition')


def maybe_skip(compat_version):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self = <apache_beam.io.gcp.bigquery_file_loads_test.TestBigQueryFileLoads testMethod=test_triggering_frequency_3>
is_streaming = True, with_auto_sharding = False, compat_version = '2.64.0'

    @parameterized.expand([
        param(is_streaming=False, with_auto_sharding=False, compat_version=None),
        param(is_streaming=True, with_auto_sharding=False, compat_version=None),
        param(is_streaming=True, with_auto_sharding=True, compat_version=None),
        param(
            is_streaming=True, with_auto_sharding=False, compat_version="2.64.0"),
        param(
            is_streaming=True, with_auto_sharding=True, compat_version="2.64.0"),
    ])
    def test_triggering_frequency(
        self, is_streaming, with_auto_sharding, compat_version):
>     maybe_skip(compat_version)
E     NameError: name 'maybe_skip' is not defined

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining tests are unrelated - merging, thanks

@damccorm
damccorm merged commit c54cc2b into apache:master Oct 13, 2025
124 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants