Exercise Spark 4 tests

[Abacn]

Please add a meaningful description for your change here

Follow up of #38255, add Spark4 test to PreCommit_Spark_Version. Handling Java version requirements

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the build configuration for Apache Beam by updating how Error Prone and Java versions are managed. The changes ensure consistent static analysis application and provide more robust handling of Java version requirements for test execution, facilitating better support for newer Java versions like Spark 4.

Highlights

• Error Prone Configuration: Enabled Error Prone static analysis unconditionally, removing the previous restriction that prevented it from running when the test Java version was set to 8.
• Java Version Handling: Improved the logic for determining the test Java version by allowing it to fall back to the forkJavaVersion if testJavaVersion is not explicitly provided.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (2)
  • .github/workflows/README.md
  • .github/workflows/beam_PreCommit_Java_Spark_Versions.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Abacn]

Tested locally with command ./gradlew :runners:spark:4:build -Pjava21Home=/Users/.../.sdkman/candidates/java/21.0.7-tem

[gemini-code-assist]

Code Review

This pull request removes the conditional guard that previously disabled Error Prone for Java 8 environments and refactors the retrieval of the testJavaVersion property. Feedback indicates that removing the Java 8 guard may cause build regressions due to known compatibility issues between Error Prone and specific JDK configurations. Additionally, a typo was identified in the UnrecognisedJavadocTag check name, which prevents it from being correctly disabled.

[Abacn]

R: @tkaymak

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[tkaymak]

Thanks for the follow-up @Abacn! LGTM.
The forkJavaVersion -> testJavaVersion fallback is the right place to fix this; it falls out cleanly from the requireJavaVersion plumbing we landed in #38324.

Left a few non-blocking suggestions inline (errorprone block being unrelated to Spark 4, plus a missing trigger file for the renamed workflow and the orphaned Spark4_Versions.json from #38255). I'm happy to roll the trigger-file cleanup into a small follow-up PR I'm already drafting for the two trailing comments you left on #38255.

[tkaymak]

Confirms the requireJavaVersion=17 plumbing from #38324 plus the new forkJavaVersion -> testJavaVersion fallback in this PR will make :runners:spark:4:build fork to JDK 17 for both compile and test on a Java-11-default CI box. With actions/setup-java's multi-line java-version putting JAVA_HOME on the last-listed entry, Spark 3 keeps its primary JDK and Spark 4 forks via -Pjava17Home=$JAVA_HOME_17_X64.