Fix iceberg gcs dependency after gcsio 3.0 upgrade#38488
Conversation
c84da86 to
be39171
Compare
|
R: @Amar3tto |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses runtime classpath issues introduced by the gcsio 3.0 upgrade. By explicitly including the necessary Hadoop utility dependencies for GCS, it ensures that the Iceberg integration can correctly identify and utilize the required file system implementations during test execution and runtime. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates a trigger file, adds a Hadoop utility dependency to the Iceberg SQL extension, and removes a Java version guard for Iceberg dependencies in the expansion service. The reviewer identified that removing the Java 8 compatibility check for Iceberg dependencies will cause an UnsupportedClassVersionError in Java 8 environments, as Iceberg 1.7.0+ requires Java 11. It is recommended to restore the guard and include the new Hadoop dependency within it.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
R: @Amar3tto also need to cherry-pick this into the release branch |
Please add a meaningful description for your change here
Follow up #38419, it appears bigdataoss_util_hadoop no longer present in runtime classpath for the test, causing
errors like
Caused by: org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme "gs"Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.