Skip to content

Sickbay two failed tests due to new schema coder urn.#38497

Merged
shunping merged 4 commits into
apache:masterfrom
shunping:sickbay-tests
May 14, 2026
Merged

Sickbay two failed tests due to new schema coder urn.#38497
shunping merged 4 commits into
apache:masterfrom
shunping:sickbay-tests

Conversation

@shunping
Copy link
Copy Markdown
Collaborator

@shunping shunping commented May 14, 2026

fixes #33859

@shunping
Copy link
Copy Markdown
Collaborator Author

r: @acrites

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@shunping shunping marked this pull request as ready for review May 14, 2026 01:22
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses failures in the ULR (Universal Local Runner) test suite caused by the introduction of a new schema coder URN that is currently only supported in Dataflow. By sickbaying these specific tests, the build stability is maintained while the underlying runner support is being addressed.

Highlights

  • Test Exclusion: Excluded two tests in PerKeyOrderingTest from the ULR ValidatesRunner suite due to a missing schema coder URN support.
  • Trigger File Update: Updated the ULR trigger file to reflect the changes in the test suite.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request excludes two tests in PerKeyOrderingTest from the Java ULR ValidatesRunner due to a 'KeyError: beam:coder:schema:v1' issue. Feedback suggests adding a TODO with a tracking issue link to these exclusions to ensure they are revisited, following the project's established pattern.

Comment thread runners/portability/java/build.gradle Outdated
@shunping shunping merged commit 3dbd7c8 into apache:master May 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Java ValidatesRunner ULR job is flaky

2 participants