[release-2.75] Cherry-pick #39096 to the branch - #39115
Conversation
Previously, in ExecutorServiceParallelExecutor, if an exception occurred during registry cleanup (such as a timeout inside DoFn teardown), the pipeline state was transitioned to terminal before the exception was queued in `visibleUpdates`. This introduced a race condition where `waitUntilFinish()` could detect the terminal state and exit successfully before the exception was offered to the updates queue, swallowing the exception. This caused tests like `CallTest.givenTeardownTimeout_throwsError` to fail since they expected the pipeline to throw an exception. This change swaps the order so that the exception is posted to `visibleUpdates` before updating the pipeline state to terminal, ensuring the exception is always propagated.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request backports a fix to the release-2.75 branch that improves the robustness of the pipeline shutdown process. By wrapping the error handling logic in a try-finally block, it ensures that the pipeline state is reliably transitioned to a terminal state regardless of whether exceptions are encountered during execution. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Run Java_IOs_Direct PreCommit |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the shutdownIfNecessary method in ExecutorServiceParallelExecutor.java to ensure that the pipeline state transition to a terminal node is executed within a finally block, even if errors are encountered. It also improves error message formatting by falling back to the exception class name if the message is null. A review comment correctly identifies that newline characters in the exception message are double-escaped, which would cause literal backslash-n characters to be printed in the logs.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Java_IOs_Direct PreCommit: https://github.com/apache/beam/actions/runs/28193260557 |
|
r: @Amar3tto |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Run Java_IOs_Direct PreCommit |
|
Java_IOs_Direct PreCommit: https://github.com/apache/beam/actions/runs/28195131915 |
2 participants
Apply #39096 to release 2.75 to fix test failure on Java_IOs_Direct PreCommit