Skip to content

IcerbergIO Load test and benchmarking#39270

Open
Amar3tto wants to merge 6 commits into
masterfrom
icerbergio-benchmark
Open

IcerbergIO Load test and benchmarking#39270
Amar3tto wants to merge 6 commits into
masterfrom
icerbergio-benchmark

Conversation

@Amar3tto

@Amar3tto Amar3tto commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Successful run: https://github.com/apache/beam/actions/runs/29006124448/job/86078012033
Read Dataflow Job: 2026-07-09_02_11_56-9909184907203270916
Write Dataflow Job: 2026-07-09_02_00_15-6048170378328054140

Changes:

  • Moved the next classes from it.gcp to it.common:
    • DefaultPipelineLauncher and AbstractPipelineLauncher
    • LoadTestBase
    • Resource managers and Artifact utils
  • Implemented Load test for IcebergIO Batch Read/Write
  • Added IcebergIO Looker diagrams with metrics to the website

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive load testing and benchmarking for IcebergIO. It includes a significant refactoring of existing integration test utilities to promote code reuse by moving common components into a shared module. Additionally, it adds support for IcebergIO performance tracking on the project's website, providing visibility into read and write performance metrics.

Highlights

  • Refactoring: Moved common integration test utilities from the gcp module to a shared common module to improve code reuse.
  • Load Testing: Implemented new load tests for IcebergIO Batch Read and Write operations.
  • Documentation and Metrics: Added IcebergIO performance metrics to the project website, including new Looker diagrams for visualization.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/beam_PostCommit_Java_IO_Performance_Tests.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces integration and performance tests for IcebergIO (IcebergIOLT), along with its corresponding Gradle tasks, website documentation, and Looker metrics configurations. Additionally, it reorganizes the integration testing framework by moving common test utilities (such as load/stress test base classes, artifact clients, and resource managers) from the GCP-specific module to a shared common module under the org.apache.beam.it.common package, updating dependencies and imports across several modules. Regarding the feedback, a performance issue was identified in the new IcebergIOLT test where a Random object is instantiated for every processed element, which can cause significant CPU and garbage collection overhead; it is recommended to reuse a single transient Random instance and update its seed instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - just had a couple of questions

Comment thread it/common/src/main/resources/test-artifact.json
@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Amar3tto

Copy link
Copy Markdown
Collaborator Author

@damccorm could you please re-review

resolutionStrategy.capabilitiesResolution.withCapability("org.lz4:lz4-java") {
select("at.yawk.lz4:lz4-java:1.10.2")
}
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because of moving some dependencies to common, there was a lz4 conflict

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @liferoad for label build.
R: @kennknowles for label website.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Amar3tto
Amar3tto requested a review from damccorm July 20, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants