Fix BeamRowWrapperTest microsecond precision flake#39287
Conversation
Use a deterministic microsecond-aligned Instant and assert the exact conversion so Java 21 clock precision cannot break test class initialization.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a test flake in BeamRowWrapperTest caused by Java 21's higher-precision clock. By replacing dynamic time generation with a deterministic fixture, the test suite now reliably handles microsecond-precision requirements without being affected by system-level nanosecond resolution. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors BeamRowWrapperTest.java to use a static Instant (TEST_MICROS_INSTANT) instead of Instant.now(), making the microsecond-precision instant logical type conversion test deterministic. The reviewer feedback suggests using Instant.parse with an ISO-8601 string for better readability and removing an unnecessary explicit cast to (long) to avoid potential null-pointer exceptions during unboxing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
ahmedabu98
left a comment
There was a problem hiding this comment.
Looks great, thanks for fixing it!
Summary
Fixes #39266.
BeamRowWrapperTestusedInstant.now()for aMicrosInstantfield. Java 21 can return nanosecond-precision values, whileMicrosInstantintentionally rejects precision finer than microseconds. The static row fixture therefore failed to initialize and all 18 tests in the class failed.Use a deterministic, microsecond-aligned
Instantfixture and assert its exact converted value. Production behavior remains unchanged.Repro command
Before this change: 18 tests failed from the static initializer. After this change: targeted class passes.
Testing
BeamRowWrapperTest: passed:sdks:java:io:iceberg:build: passed:sdks:java:io:iceberg:spotlessCheck: passedThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes. Not applicable: test-only fix.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.