Skip to content

Fix BeamRowWrapperTest microsecond precision flake#39287

Merged
ahmedabu98 merged 1 commit into
apache:masterfrom
bvolpato:bvolpato/fix-iceberg-micros-instant-flake
Jul 13, 2026
Merged

Fix BeamRowWrapperTest microsecond precision flake#39287
ahmedabu98 merged 1 commit into
apache:masterfrom
bvolpato:bvolpato/fix-iceberg-micros-instant-flake

Conversation

@bvolpato

Copy link
Copy Markdown
Contributor

Summary

Fixes #39266.

BeamRowWrapperTest used Instant.now() for a MicrosInstant field. Java 21 can return nanosecond-precision values, while MicrosInstant intentionally rejects precision finer than microseconds. The static row fixture therefore failed to initialize and all 18 tests in the class failed.

Use a deterministic, microsecond-aligned Instant fixture and assert its exact converted value. Production behavior remains unchanged.

Repro command

env JAVA_HOME=$HOME/.sdkman/candidates/java/21.0.6-tem \
  PATH=$HOME/.sdkman/candidates/java/21.0.6-tem/bin:$PATH \
  ./gradlew --no-daemon --console=plain \
  :sdks:java:io:iceberg:test \
  --tests org.apache.beam.sdk.io.iceberg.BeamRowWrapperTest

Before this change: 18 tests failed from the static initializer. After this change: targeted class passes.

Testing

  • Java 21 targeted BeamRowWrapperTest: passed
  • Java 21 :sdks:java:io:iceberg:build: passed
  • :sdks:java:io:iceberg:spotlessCheck: passed

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes. Not applicable: test-only fix.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement. Not applicable: small test-only fix.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Use a deterministic microsecond-aligned Instant and assert the exact conversion so Java 21 clock precision cannot break test class initialization.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a test flake in BeamRowWrapperTest caused by Java 21's higher-precision clock. By replacing dynamic time generation with a deterministic fixture, the test suite now reliably handles microsecond-precision requirements without being affected by system-level nanosecond resolution.

Highlights

  • Test Stability: Replaced the non-deterministic Instant.now() with a fixed, microsecond-aligned Instant fixture to prevent test failures on Java 21.
  • Precision Handling: Updated the test assertion to use a hardcoded microsecond value, ensuring compatibility with Java 21's nanosecond-precision timestamps.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors BeamRowWrapperTest.java to use a static Instant (TEST_MICROS_INSTANT) instead of Instant.now(), making the microsecond-precision instant logical type conversion test deterministic. The reviewer feedback suggests using Instant.parse with an ISO-8601 string for better readability and removing an unnecessary explicit cast to (long) to avoid potential null-pointer exceptions during unboxing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98 ahmedabu98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing it!

@ahmedabu98
ahmedabu98 merged commit 09af958 into apache:master Jul 13, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The IcebergIO Unit Tests job is flaky

2 participants