Add JVM --add-opens flags for Spark load tests on Java 21#39302
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Spark runner load test configuration to ensure compatibility with newer Java versions (17+). By conditionally adding required module-opening flags, it prevents potential runtime access errors when running tests on modern JDKs. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a sparkJvmArgs() helper function in sdks/java/testing/load-tests/build.gradle to conditionally append --add-opens JVM arguments when running Spark load tests on Java 17 or higher. The reviewer suggested a robust improvement to use Gradle's built-in JavaVersion.toVersion() helper instead of manually parsing the Java version string or integer.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| def testJavaVer = project.findProperty('testJavaVersion') ? (project.property('testJavaVersion') as int) : JavaVersion.current().majorVersion.toInteger() | ||
| if (testJavaVer >= 17) { |
There was a problem hiding this comment.
Instead of manually parsing the Java version string/integer, you can use Gradle's built-in JavaVersion.toVersion() helper. This is more robust and handles various Java version formats (e.g., "17", "1.8", etc.) gracefully.
def testJavaVer = JavaVersion.toVersion(project.findProperty('testJavaVersion') ?: JavaVersion.current())
if (testJavaVer >= JavaVersion.VERSION_17) {
Fixes: #39301, Fixes #39299, Fixes #39298, Fixes #39300
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.