Skip to content

Add Spark JVM --add-opens for (Nexmark, TPC-DS, PortableJar)#39337

Merged
Abacn merged 1 commit into
apache:masterfrom
aIbrahiim:fix-nexmark-spark-add-opens
Jul 15, 2026
Merged

Add Spark JVM --add-opens for (Nexmark, TPC-DS, PortableJar)#39337
Abacn merged 1 commit into
apache:masterfrom
aIbrahiim:fix-nexmark-spark-add-opens

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Fixes: #39265, #39263, #39262

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues when running Nexmark tests on newer Java versions. By configuring specific JVM 'add-opens' flags for the Spark runner, the changes ensure that the test suite can properly access internal Java modules required for execution on JDK 17+ environments.

Highlights

  • JVM Compatibility: Added necessary JVM arguments to support running Nexmark tests on Java 17 and higher.
  • Build Configuration: Introduced a helper function in the build script to dynamically inject '--add-opens' flags for Spark-based test executions.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the java label Jul 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helper method sparkJvmArgs() in sdks/java/testing/nexmark/build.gradle to conditionally append JVM --add-opens arguments when running with Java 17 or higher. The reviewer suggested a more robust way to parse and compare the Java version using Gradle's JavaVersion.toVersion() to prevent potential NumberFormatException errors when parsing version strings.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +118 to +119
def testJavaVer = project.findProperty('testJavaVersion') ? (project.property('testJavaVersion') as int) : JavaVersion.current().majorVersion.toInteger()
if (testJavaVer >= 17) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Parsing testJavaVersion directly as an integer using as int can throw a NumberFormatException if the version is specified in a format like "1.8" or "11.0".

Using Gradle's built-in JavaVersion.toVersion() is much more robust as it correctly handles various Java version string formats (e.g., "1.8", "8", "17") and allows for safe comparison using JavaVersion enum constants.

  def testJavaVer = project.findProperty('testJavaVersion') ? JavaVersion.toVersion(project.property('testJavaVersion')) : JavaVersion.current()
  if (testJavaVer >= JavaVersion.VERSION_17) {

@aIbrahiim
aIbrahiim force-pushed the fix-nexmark-spark-add-opens branch from dc0dab9 to 6378940 Compare July 15, 2026 08:27
@aIbrahiim aIbrahiim changed the title add Spark JVM --add-opens for Nexmark Add Spark JVM --add-opens for (Nexmark, TPC-DS, PortableJar) Jul 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

cc: @Abacn

@Abacn
Abacn merged commit 48eab4f into apache:master Jul 15, 2026
31 of 32 checks passed
rwiggles pushed a commit to rwiggles/beam-rwiggles that referenced this pull request Jul 17, 2026
Abacn added a commit that referenced this pull request Jul 23, 2026
* Support logging the key during a KeyCommitTooLarge if EnableHotKeyLogging is turned on. Also switch to logging the dfe name instead of the computation name and fix an overflow in logging the sharding key

* Update runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/KeyCommitTooLargeException.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/StreamingWorkScheduler.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* gemini review responses

* Fix imports

* one more

* one more attempt

* one more attempt

* formatting fix

* Bump actions/checkout from 6 to 7 (#39335)

Bumps [actions/checkout](https://github.com/actions/checkout) from 6 to 7.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v6...v7)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump cloud.google.com/go/datastore from 1.24.0 to 1.25.0 in /sdks (#39333)

Bumps [cloud.google.com/go/datastore](https://github.com/googleapis/google-cloud-go) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/documentai/CHANGES.md)
- [Commits](googleapis/google-cloud-go@kms/v1.24.0...kms/v1.25.0)

---
updated-dependencies:
- dependency-name: cloud.google.com/go/datastore
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/aws/aws-sdk-go-v2/feature/s3/manager in /sdks (#39334)

Bumps [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) from 1.22.32 to 1.22.33.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@feature/s3/manager/v1.22.32...feature/s3/manager/v1.22.33)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager
  dependency-version: 1.22.33
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix DataflowV1 test failure by fixing getSimpleName access (#39330)

* add jdkAddOpenModules for Dataflow V2 (#39306)

* Add Spark JVM --add-opens for (Nexmark, TPC-DS, PortableJar) (#39337)

* add Spark job-server --add-opens (#39339)

* fix: add retries and query parameter encoding for GitHub API requests (closes #39188)

* fix: add Apache license header to test_sending.py

* Move validation to StreamingModeExecutionContext

* remove unused import

* respond to comments

* bugfix

* Update runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java

Co-authored-by: Arun Pandian <arunpandianp@gmail.com>

* respond to comments

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yi Hu <yathu@google.com>
Co-authored-by: Abdelrahman Ibrahim <abdoibrahim1017@gmail.com>
Co-authored-by: raman118 <rcho38706@gmail.com>
Co-authored-by: Arun Pandian <arunpandianp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Java Nexmark Spark job is flaky

2 participants