Fix scheduled Iceberg performance test checkout - #39493
Open
bvolpato wants to merge 1 commit into
Open
Conversation
Scheduled IO performance jobs use the latest Beam release, but IcebergPerformanceTest was added after v2.75.0 and is unavailable there. Keep that matrix entry on the master checkout while preserving release testing for existing jobs.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
|
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38694
Scheduled Java IO performance runs build their matrix from
master, then check out latest release before running each Gradle task.IcebergPerformanceTestwas added after v2.75.0, so scheduled runs consistently fail because that release does not contain:it:IcebergPerformanceTest.Keep Iceberg performance job on initial
mastercheckout. Existing scheduled performance jobs continue testing latest release, and manually triggered runs remain unchanged.Validation:
./gradlew --no-daemon :beam-test-gha:preCommitgit diff --checkIcebergPerformanceTestexists onmasterand is absent from v2.75.0Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
CHANGES.mdis not needed for this workflow-only fix.See the Contributor Guide for more tips on making the reviewer's job easier.
To check build health, visit .test-infra/BUILD_STATUS.md.
See CI.md for GitHub workflow details.