Skip to content

Fix dataframe CSV tests on Windows - #39563

Open
Guflly wants to merge 1 commit into
apache:masterfrom
Guflly:fix/windows-dataframe-io-tests
Open

Fix dataframe CSV tests on Windows#39563
Guflly wants to merge 1 commit into
apache:masterfrom
Guflly:fix/windows-dataframe-io-tests

Conversation

@Guflly

@Guflly Guflly commented Jul 31, 2026

Copy link
Copy Markdown

Fixes #20642.

The dataframe CSV sink wrapped a binary stream with default newline translation, which turned pandas CRLF endings into extra blank lines on Windows. Windowed test filenames also used colon-containing timestamps.

This disables newline translation for text sinks and uses the existing Windows-safe naming pattern in the windowed test, allowing the full IO test class to run on Windows.

Tests:

  • python -m pytest -q apache_beam\dataframe\io_test.py (33 passed, 5 skipped)
  • python -m yapf --diff apache_beam\dataframe\io.py apache_beam\dataframe\io_test.py

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @jrmccluskey for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix csv reading tests on Windows

1 participant