Migrate Vertex AI Model Handler to new base class#34578
Conversation
|
Green Python PostCommit run against refactored class - https://github.com/apache/beam/actions/runs/14336422141 |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Much cleaner. Thanks. |
|
I think this was a breaking change since |
|
Do you directly use |
Hi, thanks for the reply. We have a use case where we customised |
I see. |
Simplifies the Vertex AI model handler implementation by migrating to the new RemoteModelHandler base class. Should be a backwards-compatible change, as the args to the constructor have not changed.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.