Skip to content

Migrate Vertex AI Model Handler to new base class#34578

Merged
jrmccluskey merged 1 commit intomasterfrom
vertexRefactor
Apr 10, 2025
Merged

Migrate Vertex AI Model Handler to new base class#34578
jrmccluskey merged 1 commit intomasterfrom
vertexRefactor

Conversation

@jrmccluskey
Copy link
Copy Markdown
Contributor

Simplifies the Vertex AI model handler implementation by migrating to the new RemoteModelHandler base class. Should be a backwards-compatible change, as the args to the constructor have not changed.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@jrmccluskey
Copy link
Copy Markdown
Contributor Author

Green Python PostCommit run against refactored class - https://github.com/apache/beam/actions/runs/14336422141

@jrmccluskey jrmccluskey marked this pull request as ready for review April 9, 2025 19:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@liferoad
Copy link
Copy Markdown
Contributor

liferoad commented Apr 9, 2025

Much cleaner. Thanks.

@jrmccluskey jrmccluskey merged commit cb0b7d1 into master Apr 10, 2025
95 checks passed
@damccorm damccorm deleted the vertexRefactor branch April 15, 2025 18:10
@senim2
Copy link
Copy Markdown

senim2 commented Jul 28, 2025

I think this was a breaking change since run_inference public method was removed.

@liferoad
Copy link
Copy Markdown
Contributor

Do you directly use run_inference in VertexAIModelHandlerJSON?

@senim2
Copy link
Copy Markdown

senim2 commented Jul 28, 2025

Do you directly use run_inference in VertexAIModelHandlerJSON?

Hi, thanks for the reply. We have a use case where we customised VertexAIModelHandlerJSON by extending it and customising the behaviour inside the run_inference public method.

@liferoad
Copy link
Copy Markdown
Contributor

Do you directly use run_inference in VertexAIModelHandlerJSON?

Hi, thanks for the reply. We have a use case where we customised VertexAIModelHandlerJSON by extending it and customising the behaviour inside the run_inference public method.

I see. run_inference is now the part of RemoteModelHandler. You could still customize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants