Skip to content

Fix: Handle invalid bucket path warning in Beam Python SDK - #35744

Closed
yquaziii wants to merge 2 commits into
apache:masterfrom
yquaziii:fix-invalid-bucket-path
Closed

Fix: Handle invalid bucket path warning in Beam Python SDK#35744
yquaziii wants to merge 2 commits into
apache:masterfrom
yquaziii:fix-invalid-bucket-path

Conversation

@yquaziii

Copy link
Copy Markdown

Please add a meaningful description for your change here

Added warning if the stage_location and temp_location is invalid it will try to create default bucket.
Fixes #35584

Tested :
AxsXncGrX2sDKhB


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @yquaziii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience in the Apache Beam Python SDK by providing more transparent feedback. It adds a specific warning message that alerts users when their configured temporary and staging GCS bucket locations are not valid, indicating that the system will proceed by creating and using a default GCS bucket instead.

Highlights

  • User Feedback: Introduced a new warning message in pipeline_options.py to explicitly inform users when their specified temp_location and staging_location for GCS buckets are deemed invalid, leading the system to fall back to creating a default GCS bucket.
  • Error Handling Clarity: Improved the clarity of how the Apache Beam Python SDK handles scenarios where GCS bucket paths are not explicitly erroneous but are still unusable, by logging a clear warning about the automatic fallback to a default bucket.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a warning when both staging_location and temp_location are invalid. However, the warning is added to a code block that executes when both locations are valid, which would lead to confusing and incorrect warnings. I've suggested moving the warning to the correct block that handles invalid locations.

Comment thread sdks/python/apache_beam/options/pipeline_options.py
@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

return []
# Both staging and temp locations are bad, try to use default bucket.
else:
_LOGGER.warning(

@Abacn Abacn Jul 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is valid when error is "ERR_MISSING_GCS_PATH". We should only issue warning when either is "ERR_INVALID_GCS_PATH"

@derrickaw

Copy link
Copy Markdown
Collaborator

waiting on author

@stankiewicz

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Nov 24, 2025
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Resilient Fallback log and Auto-Creation of Default Storage Bucket.

4 participants